Skip to content

docs: fix protocol claim fees account list - #228

Open
callumweb3 wants to merge 1 commit into
magicblock-labs:mainfrom
callumweb3:patch-1
Open

docs: fix protocol claim fees account list#228
callumweb3 wants to merge 1 commit into
magicblock-labs:mainfrom
callumweb3:patch-1

Conversation

@callumweb3

@callumweb3 callumweb3 commented Aug 23, 2026

Copy link
Copy Markdown

Problem

The process_protocol_claim_fees documentation was missing the delegation_program_data account required by the implementation.

Solution

Updated the account documentation to include all three required accounts with their correct indices and order.

The delegation_program_data account is required by the code to load the protocol program upgrade authority.

Before & After Screenshots

Documentation-only change.

Deploy Notes

No deployment changes.

Summary by CodeRabbit

  • Documentation
    • Updated account documentation for fee claiming to include the required delegation program data account.
    • Clarified the order and indexing of accounts used during fee-claim processing.

Update the `process_protocol_claim_fees` account documentation to match the accounts required by the implementation.

The docs were missing the `delegation_program_data` account, while the code requires it to load the protocol program upgrade authority. The account list now documents all three accounts with their correct indices and order.
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0cc7eecf-4970-48b8-8645-f0ff78a46f92

📥 Commits

Reviewing files that changed from the base of the PR and between 6898ef4 and 93e8a5d.

📒 Files selected for processing (1)
  • src/processor/protocol_claim_fees.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Updated the protocol fee processor account documentation. The documentation now identifies the admin signer and protocol fees vault by index and adds the delegation program data account at index 2.

Merge Risk: ⚪ Minimal · up to 93e8a

This documentation-only update adds the required account entry and does not introduce an actionable merge-blocking risk; it is merge-ready after normal checks and review.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant