test: live e2e suite for ephemeral cranks - #19
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
from
August 13, 2026 10:28
dbd2e90 to
698daca
Compare
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
from
August 13, 2026 14:33
ae5dd7f to
aecc608
Compare
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
from
August 13, 2026 14:49
aecc608 to
43b5073
Compare
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
from
August 13, 2026 17:53
43b5073 to
0a77f49
Compare
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
2 times, most recently
from
August 13, 2026 22:22
a5e6376 to
0826aa6
Compare
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
3 times, most recently
from
August 14, 2026 08:13
2b7ed5d to
9b9b02b
Compare
Dodecahedr0x
marked this pull request as ready for review
August 14, 2026 09:33
GabrielePicco
approved these changes
Aug 20, 2026
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
from
August 26, 2026 10:02
9544583 to
a40cbcf
Compare
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
from
August 26, 2026 10:07
a40cbcf to
bf84508
Compare
Boots mb-test-validator + ephemeral-validator + hydra-cranker and asserts cranks fire on schedule inside the rollup. noop now logs `noop-fired:<id>` so fires are attributed via logsSubscribe instead of polling account state. Adds the e2e job to CI and the lint-e2e / test-e2e Makefile targets.
`terminate` shelled out to `kill -INT -<pgid>`. BSD kill (macOS) reads the bare `-<pgid>` as a negative PID, but procps-ng kill (Linux/CI) parses it as another option and exits 0 without signalling anything. The exit status was discarded and stderr sent to /dev/null, so the no-op was invisible. The cranker therefore never saw SIGINT on CI, skipped its graceful shutdown, and never ran the undelegate — failing both scenarios with "still delegated 30s after shutdown" while the cranks themselves fired and closed correctly. `kill -s SIG -- -<pgid>` ends option parsing and delivers on both platforms. Verified: on ubuntu:24.04 the old form reports rc=0 with the handler never running, the new form delivers; the full suite still passes on macOS (3/3).
Dodecahedr0x
force-pushed
the
stack/7-e2e
branch
from
August 26, 2026 10:12
bf84508 to
0316ed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Boots mb-test-validator + ephemeral-validator + hydra-cranker and asserts
cranks fire on schedule inside the rollup. noop now logs
noop-fired:<id>so fires are attributed via logsSubscribe instead of polling account state.
Adds the e2e job to CI and the lint-e2e / test-e2e Makefile targets.
Stack created with GitHub Stacks CLI • Give Feedback 💬