fix: reconstruct recent blockhash history - #88
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughKeeper startup now reconstructs recent blockhash history from retained ledger blocks and persisted 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation Docstring coverage is 94.12% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 5 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
SlotHasheswith older retained ledger entries and preserve original slots for TTL expiry.SlotHashesaccount.Closes #87
Impact
Verifier-only restarts retain recent blockhash validity consistent with the uninterrupted leader when ledger history is available. Snapshot-staged AccountsDB instances without ledger history continue to fall back to persisted
SlotHashes. No public API or storage encoding changes.Reviewer notes
AccountsDB is the recovery authority: ledger entries newer than its slot are ignored because they may belong to an uncommitted crash tail. Ledger block ranges are consumed newest-first.