Skip to content

Share one SQL tokenizer between SqlTableReference and LibsqlResultSetMetaData #111

Closed

Description

@magnusp

#70 grew SqlTableReference.java from 266 to 1149 lines. The file is now over 1000 lines.

LibsqlResultSetMetaData keeps a second near-identical tokenizer for the auto-increment check from #56. It has its own token record, tokenize, skipQuoted, unescape, and isWordChar. Any tokenizer defect exists twice.

Inside the parser, matchingParen and matchingParenIn, identifiers and identifiersIn, and indexOfWord and indexOfWordIn duplicate each other.

Expected:

  • Extract one SqlTokenizer with a token type, a depth, and a literal kind.
  • Use it from the parser and from the CREATE TABLE scanner.
  • Remove the duplicated helpers.
  • Do this after the parser defect issues, so the fixes land on one implementation.

Activity

  1. added
    enhancementNew feature or request
    P2Normal priority: edge case, feature gap, or test/process improvement
    on Oct 22, 2026
  2. added a commit that references this issue on Oct 23, 2026
    7c7d321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal priority: edge case, feature gap, or test/process improvementenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions