Skip to content

Metadata statement cleanup depends on closeOnCompletion behavior that #86 proposes to change #119

Closed

Description

@magnusp

#91 closes metadata statements through executeMetadataQuery. The statement closes only because closeOnCompletion auto-closes it when the result set closes. #86 proposes to match sqlite-jdbc, which only tracks that flag.

LibsqlResultSet already has a closeStatementOnClose flag, but no caller sets it to true, so it is dead code.

If #86 is fixed the sqlite-jdbc way, the leak returns for every metadata method. Only MetadataLeakTest would notice, and it exercises getTables only.

Expected:

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal priority: edge case, feature gap, or test/process improvementbugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions