Skip to content

Duplicate checkClosed call in Statement and PreparedStatement execute #81

Closed
#150
Closed
Duplicate checkClosed call in Statement and PreparedStatement execute#81
#150
Labels
P2Normal priority: edge case, feature gap, or test/process improvementbugSomething isn't working

Description

@magnusp
magnusp
opened on Oct 21, 2026

Found during the #29 replay. LibsqlStatement.execute(String) and LibsqlPreparedStatement.execute() both call checkClosed(); closeCurrentResultSet(); checkClosed();. The second check is redundant after #28.

Expected: keep one closed check before the state transition, with no behavior change.

Activity

  1. magnusp
    added
    bugSomething isn't working
    P2Normal priority: edge case, feature gap, or test/process improvement
    on Oct 21, 2026
  2. magnusp
    closed this as completedin #150on Oct 23, 2026
  3. magnusp
    added a commit that references this issue on Oct 23, 2026

    fix(jdbc): drop duplicate checkClosed in prepared execute (#150)

    ffe6f19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal priority: edge case, feature gap, or test/process improvementbugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions