Repository navigation
ci(pr): run PR verification for every base branch - #130
Merged
Merged
Conversation
Remove the main-only branches filter from the pull_request trigger so a PR stacked on a feature branch gets the same Build & Test checks as one based on main. Job graph, permissions, and check names are unchanged. Fixes #80
Drop the main-only branches filter from the pull_request trigger so a PR stacked on a feature branch still gets CodeQL analysis. push and schedule triggers are unchanged. Fixes #80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80
Three-layer contract: Hrana 3 remains the transport source of truth (untouched),
java.sqlthe JDBC surface source of truth (untouched), and xerial/sqlite-jdbc only a behavioural reference (untouched). This PR is CI configuration only.Change
Two workflows filtered
pull_requestto base branchmain, so a PR stacked on a feature branch got neitherPR Verificationnor CodeQL. Both filters are removed.pushandscheduletriggers, permissions, job graphs, and check names are unchanged..github/workflows/pr.yml.github/workflows/codeql.ymlA bare
pull_request:means every base branch and the default activity types, which are exactlyopened,synchronize,reopened— the same setpr.ymlstill lists explicitly.Red / green
pull_requesttriggers carrybranches: ["main"]; a PR based on a feature branch starts neither workflow.pr.ymlnorcodeql.ymlfilterspull_requestby base branch, soBuild & Test (Java 25/26)andAnalyze Code with CodeQLmatch every PR base.Lanes
pr.ymlhas no base filter,codeql.ymlhaspull_request: None(all bases); the only remainingbranches:is underpush(lane-2-specific.log) — pass.actionlintis not installed in this environment, so the plan's fallback parse was used../mvnw -pl libsql-jdbc test: 223 tests, BUILD SUCCESS (lane-5-unit.log) — pass.git diff origin/main -- .github/workflows: two removed lines, one per workflow (lane-6-diff.log) — pass.pr.yml→verify;codeql.yml→analyze(lane-7-jobs.log) — pass../mvnw -q validateBUILD SUCCESS (lane-8-validate.log) — pass.spotless:checkclean.Build & Test (Java 25),Build & Test (Java 26),Analyze Code with CodeQL(lane-10-checks.log) — pass.Perf:
./mvnw -pl libsql-jdbc test; trunk median 2370 ms at 5401ce9, head medians 2396 ms at c2a6891 and 2269 ms at cd15094 — inside the 10% rule.Divergences
.github/workflows/codeql.ymlwas added to the plan's Files block by the queue owner after the first push, because the plan's "You see" box requires CodeQL coverage for stacked PRs and CodeQL is defined there, not inpr.yml.mise exec --; the queue owner brief forbids it (mise tries to install an unrelated tool and fails), so lanes ran with./mvnwdirectly.Base SHA: 5401ce9
Head SHA: cd15094