Skip to content

fix(jdbc): wrap REAL to int like SQLite #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magnusp merged 1 commit into from
Oct 22, 2026
Merged

fix(jdbc): wrap REAL to int like SQLite #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libsql-jdbc/src/main/java/com/github/magnusp/libsql/jdbc/LibsqlResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ public int getInt(int columnIndex) throws SQLException {
return switch (val) {
case Value.Null n -> 0;
case Value.Integer i -> (int) i.value();
case Value.Float f -> (int) f.value();
case Value.Float f -> (int) (long) f.value();
case Value.Text t -> (int) parseSqliteLong(t.value());
case Value.Blob b -> (int) parseSqliteLong(blobAsText(b));
};
Expand All @@ -474,7 +474,7 @@ public float getFloat(int columnIndex) throws SQLException {
Value val = getCurrentValue(columnIndex);
return switch (val) {
case Value.Null n -> 0.0F;
case Value.Integer i -> (float) i.value();
case Value.Integer i -> (float) (double) i.value();
case Value.Float f -> (float) f.value();
case Value.Text t -> (float) parseSqliteDouble(t.value());
case Value.Blob b -> (float) parseSqliteDouble(blobAsText(b));
Expand Down
24 changes: 24 additions & 0 deletions libsql-jdbc/src/test/java/com/github/magnusp/libsql/jdbc/LibsqlResultSetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,30 @@ void realStorageTruncatesForIntegralGettersAndKeepsFractionForFloatingGetters()
assertNumeric(rs, 1, 1, 1L, 1.9f, 1.9);
}

@Test
void realStorageWrapsToIntThroughInt64LikeSqlite() throws SQLException {
LibsqlResultSet rs = resultSet(new Value.Float(3e9), new Value.Float(-3e9));

assertThat(rs.next()).isTrue();
assertThat(rs.getInt(1)).isEqualTo(-1294967296);
assertThat(rs.getObject(1, Integer.class)).isEqualTo(-1294967296);
assertThat(rs.getInt(2)).isEqualTo(1294967296);
}

@Test
void getBooleanOnWrappingRealIsFalse() throws SQLException {
LibsqlResultSet rs = resultSet(new Value.Float(4294967296.0));
assertThat(rs.next()).isTrue();
assertThat(rs.getBoolean(1)).isFalse();
}

@Test
void getFloatOnLargeIntegerRoundsThroughDouble() throws SQLException {
LibsqlResultSet rs = resultSet(new Value.Integer(1152921573326323713L));
assertThat(rs.next()).isTrue();
assertThat(rs.getFloat(1)).isEqualTo(1.1529215E18f);
}

@Test
void integerStorageIsReturnedUnchanged() throws SQLException {
LibsqlResultSet rs = resultSet(new Value.Integer(42));
Expand Down
Loading