Repository navigation
docs: document nono Docker workaround for libsql-itests - #135
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
Docs-only change. Hrana 3 remains the source of truth for transport, values, metadata, batching, transactions, and error reporting;
java.sqlremains the source of truth for the JDBC surface; xerial/sqlite-jdbc remains a behavioral reference, never a copy target. This section is protocol-neutral and covers the sqld container both integration modules drive.What changed
AGENTS.mdsection 4 now names one shared readable Docker config,libsql-conformance/src/test/docker-config/config.json, and documents theDOCKER_CONFIGoverride thatlibsql-itestsneeds under nono. It also scopes the "shellDOCKER_CONFIGis not enough" note to conformance, since the itests Failsafe fork inherits the shell value. A pointer was added under the itests commands, and the stalenono statusreference is removed.Red, at base 599b65d
./mvnw -pl libsql-itests -am -Dit.test=LibsqlJdbcIT verifywithDOCKER_CONFIGunset fails:ServiceConfigurationError: ... EnvironmentAndSystemPropertyClientProviderStrategy could not be instantiated, caused byFileNotFoundException: /home/magnus/.docker/config.json (Permission denied). Log in/tmp/xerial-parity-i79/red-itest.log.Green, at head 25bcdca
DOCKER_CONFIG="$PWD/libsql-conformance/src/test/docker-config" ./mvnw -pl libsql-itests -am -Dit.test=LibsqlJdbcIT verifypasses, 4 tests.DOCKER_CONFIG="$PWD/libsql-conformance/src/test/docker-config" ./mvnw clean verifypasses the whole reactor, both modules, exit 0../mvnw -pl libsql-conformance -am verify, exit 0, and the-Ddocker.config.diroverride, exit 0../mvnw -q validateexits 0,./mvnw spotless:checkis clean,git diff main --statisAGENTS.mdonly../mvnw -pl libsql-jdbc testmedian 2.111s at trunk, 2.098s at head, three interleaved runs each. No Java changed.Lanes
DOCKER_CONFIGguidance, head has both commands. Pass.HikariCpIntegrationIT, pass.AGENTS.mdonly, 24 insertions, 4 deletions. Pass.npx marked AGENTS.mdshows 5 h2, 5 h3, balanced code fences. Pass../mvnw -q validate, exit 0. Pass.mise execis unavailable in this runtime, so the equivalents ran with./mvnwas the brief directs.Divergence: the plan's lanes spell
mise exec -- ./mvnw; every Maven command here ran as./mvnwper the queue brief, becausemise exectries to install an unrelated tool in this environment.All logs are under
/tmp/xerial-parity-i79/.