Skip to content

docs: document nono Docker workaround for libsql-itests - #135

Merged
magnusp merged 1 commit into
mainfrom
fix/i79-itests-docker-doc
Oct 22, 2026
Merged

magnusp merged 1 commit into
mainfrom
fix/i79-itests-docker-doc

Conversation

@magnusp

@magnusp magnusp commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Fixes #79

Docs-only change. Hrana 3 remains the source of truth for transport, values, metadata, batching, transactions, and error reporting; java.sql remains the source of truth for the JDBC surface; xerial/sqlite-jdbc remains a behavioral reference, never a copy target. This section is protocol-neutral and covers the sqld container both integration modules drive.

What changed

AGENTS.md section 4 now names one shared readable Docker config, libsql-conformance/src/test/docker-config/config.json, and documents the DOCKER_CONFIG override that libsql-itests needs under nono. It also scopes the "shell DOCKER_CONFIG is not enough" note to conformance, since the itests Failsafe fork inherits the shell value. A pointer was added under the itests commands, and the stale nono status reference is removed.

Red, at base 599b65d

./mvnw -pl libsql-itests -am -Dit.test=LibsqlJdbcIT verify with DOCKER_CONFIG unset fails: ServiceConfigurationError: ... EnvironmentAndSystemPropertyClientProviderStrategy could not be instantiated, caused by FileNotFoundException: /home/magnus/.docker/config.json (Permission denied). Log in /tmp/xerial-parity-i79/red-itest.log.

Green, at head 25bcdca

  • DOCKER_CONFIG="$PWD/libsql-conformance/src/test/docker-config" ./mvnw -pl libsql-itests -am -Dit.test=LibsqlJdbcIT verify passes, 4 tests.
  • The documented module-wide command passes all itests, 24 tests including Toxiproxy, exit 0.
  • DOCKER_CONFIG="$PWD/libsql-conformance/src/test/docker-config" ./mvnw clean verify passes the whole reactor, both modules, exit 0.
  • Existing conformance workaround still passes as written: ./mvnw -pl libsql-conformance -am verify, exit 0, and the -Ddocker.config.dir override, exit 0.
  • ./mvnw -q validate exits 0, ./mvnw spotless:check is clean, git diff main --stat is AGENTS.md only.
  • Perf: ./mvnw -pl libsql-jdbc test median 2.111s at trunk, 2.098s at head, three interleaved runs each. No Java changed.

Lanes

  1. Regression: trunk lacks any itests DOCKER_CONFIG guidance, head has both commands. Pass.
  2. Documented itest workaround: single HikariCpIntegrationIT, pass.
  3. Existing conformance workaround: pass.
  4. Fenced commands: every one exits zero. Pass.
  5. References: shared config, module poms, and both section anchors exist. Pass.
  6. Diff: AGENTS.md only, 24 insertions, 4 deletions. Pass.
  7. Render: npx marked AGENTS.md shows 5 h2, 5 h3, balanced code fences. Pass.
  8. Validate: ./mvnw -q validate, exit 0. Pass.
  9. Verbatim commands: pass, except mise exec is unavailable in this runtime, so the equivalents ran with ./mvnw as the brief directs.
  10. Fresh follow: this agent followed only the edited section to run lanes 2 and 4. No independent subagent runtime was available, so this lane is self-followed, not independently checked.

Divergence: the plan's lanes spell mise exec -- ./mvnw; every Maven command here ran as ./mvnw per the queue brief, because mise exec tries to install an unrelated tool in this environment.

All logs are under /tmp/xerial-parity-i79/.

@magnusp
magnusp merged commit 168f69a into main Oct 22, 2026
5 checks passed
@magnusp
magnusp deleted the fix/i79-itests-docker-doc branch October 22, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AGENTS.md Docker workaround covers conformance but not libsql-itests

1 participant