Repository navigation
fix(protests,sled): match the API's protest enum casing, add naics_code, carry delisted_at in SLED shapes - #6
Merged
Merged
Conversation
…de, carry delisted_at in SLED shapes The protests rustdoc showed `source_system` as `"GAO"`/`"COFC"` and `outcome` as `"sustained"`, but the API returns lowercase sources (`gao`, `cofc`, `sba_oha`) and title-case outcomes (`Sustained`, `Denied`, ...). Filters are case-insensitive, so queries worked, but code comparing returned values against the documented examples would miss every match. The protests module doc now names SBA OHA alongside GAO and COFC, and lists its extra outcomes. `ListProtestsOptions` gains `naics_code`, the one protest filter the SDK was missing; it matches the NAICS code at issue in SBA OHA size and NAICS appeals. `SHAPE_SLED_OPPORTUNITIES_MINIMAL` and `_COMPREHENSIVE` now include `delisted_at`, as the API's own list and detail default shapes do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ListProtestsOptionsandProtestRecordshowedsource_systemas"GAO"/"COFC"andoutcomeas"sustained". The API returns lowercase sources (gao,cofc,sba_oha) and title-case outcomes (Denied,Dismissed,Withdrawn,Sustained, plusGranted,Remanded,Reversed,Vacatedfor SBA OHA). Filters are case-insensitive, so queries worked, but code comparing returned values against the documented examples would never match. Test fixtures now use the real casing too.docs/API_REFERENCE.md.naics_codeoption onListProtestsOptions, the one API protest filter the SDK lacked. Only SBA OHA size and NAICS appeals carry a code, so GAO and COFC records never match.agencyrustdoc now says what the filter accepts (name, abbreviation or code,|for multiple values).delisted_atin both suggested opportunity shapes, matching the API's own list and detail defaults, with a note on how it drivesstatus_reason = "delisted".Tests
list_protests_naics_code_emits:naics_codeserializes to thenaics_codequery param. Fails to compile onmain(no such builder method); passes here.suggested_opportunity_shapes_carry_delisted_at: bothSHAPE_SLED_OPPORTUNITIES_*constants namedelisted_at. Fails onmain; passes here.just ciequivalent is green:cargo fmt --all -- --check,cargo clippy --workspace --all-features --all-targets -- -D warnings,cargo test --workspace.Relationship to open PRs
[Unreleased]section ofCHANGELOG.md, a trivial both-sides-add conflict.shapes.rsanddocs/API_REFERENCE.mdauto-merge.maininCHANGELOG.mdandcrates/tango/src/lib.rs; this branch adds nothing beyond the sameCHANGELOG.mdsection.🤖 Generated with Claude Code