Repository navigation
feat(vehicles): request holder_count and order_winner_count in the default vehicle shapes - #9
Draft
makegov-mark[bot] wants to merge 2 commits into
Draft
makegov-mark[bot] wants to merge 2 commits into
makegov-mark[bot] wants to merge 2 commits into
Conversation
…fault vehicle shapes Tango API 5.8.0 adds two company counts to vehicles: holder_count (distinct companies holding one of the vehicle's IDVs) and order_winner_count (distinct companies that have won a task order under it). awardee_count is now a deprecated alias of order_winner_count and stays in the shapes so existing readers keep working. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…go crate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SHAPE_VEHICLES_MINIMAL(default forlist_vehicles) andSHAPE_VEHICLES_COMPREHENSIVE(default forget_vehicle) now requestholder_countandorder_winner_count, right afterawardee_count.shapes::tests::vehicle_shapes_carry_company_countsasserts both default vehicle shapes carryawardee_count,holder_countandorder_winner_count.CHANGELOG.md(Unreleased,makegov-tango: Added + Deprecated).Why
Tango API 5.8.0 adds two company counts to vehicles, both in the API's default list and detail shapes:
holder_count: distinct companies holding one of the vehicle's IDVs.order_winner_count: distinct companies that have won a task order under the vehicle.awardee_countis now a deprecated alias oforder_winner_countand will be removed at the API's next major version. The SDK keeps requesting it so existing readers don't break; new code should readorder_winner_count.Vehicles return untyped records in this SDK, so there is no struct to extend.
Merge timing
Merge only after the Tango API 5.8.0 deploy is live. Before then the API rejects the two new field names in a shape, so
list_vehicles/get_vehiclewith the default shapes would fail.Testing
cargo test --workspace: all pass (263 unit tests inmakegov-tango, plus the integration-style and doc suites).cargo clippy --workspace --all-features -- -D warnings: clean.cargo fmt --all -- --check: clean.🤖 Generated with Claude Code