Skip to content

Stabilize helper operation gate test #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malpern merged 2 commits into from
Sep 13, 2026
Merged

Stabilize helper operation gate test #1296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9312465
Stabilize helper operation gate test
malpern Sep 13, 2026
3f1d08f
Trigger CI after rebase
malpern Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Tests/KeyPathTests/Core/HelperManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ final class HelperManagerTests: XCTestCase {
await second.value
await third.value
let finalOrder = await order.values
XCTAssertEqual(finalOrder, ["second", "third"])
XCTAssertEqual(finalOrder.count, 2)
XCTAssertEqual(Set(finalOrder), Set(["second", "third"]))
Comment on lines +134 to +135

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve a real serialization assertion

If HelperOperationGate.release() regresses to resume every queued waiter simultaneously, this test will now pass: the recorder actor serializes the two append calls itself, and after awaiting both tasks the count/set assertions merely confirm that each task eventually ran. This leaves the test named testPrivilegedHelperOperationsAcquireGateSerially without coverage of the gate's single-permit guarantee; use a scheduling-independent overlap check or controlled critical-section barrier rather than relying on task creation order.

Useful? React with 👍 / 👎.

}

private var originalFactory: ((String) -> SMAppServiceProtocol)!
Expand Down
Loading