Skip to content

Complete shell assignment workflow - #1

Merged
margaretcdeleon merged 3 commits into
mainfrom
assignment_shell
Oct 6, 2026
Merged

margaretcdeleon merged 3 commits into
mainfrom
assignment_shell

Conversation

@margaretcdeleon

Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I updated the project setup script to organize the client data into a standardized directory structure. The changes create data/raw and data/processed directories, organize server, user, and event log files into separate folders, remove files containing IP address information for privacy, and generate an inventory of the processed files.

What did you learn from the changes you have made?

I learned how to use shell commands to create and organize directories, move and copy files using filename patterns, remove files based on naming conventions, and use find to generate an inventory of files. I also learned how the -p option with mkdir can create nested directories when their parent directories do not already exist.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I considered creating each processed-data directory with separate mkdir commands, but using mkdir -p allowed me to create all three directories more efficiently in one command. I also could have used separate find commands to identify and copy each type of log file, but wildcard patterns such as server.log were simpler for this task.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

One challenge was making sure the directory structure existed before moving or copying files into it. I addressed this by creating the required directories first and using mkdir -p for the nested processed-data directories. I also used rm -f when removing IP address files so that the script would not fail if no matching files were found.

How were these changes tested?

I tested the changes by running the setup script and checking the resulting directory structure and files. I used ls -la data/raw to verify the raw files, checked the server_logs, user_logs, and event_logs directories to confirm that the correct log files were copied, and verified that files containing ipaddr were removed. I also checked data/inventory.txt to confirm that it contained the files within the processed-data subdirectories.

A reference to a related issue in your repository (if applicable)

N/A

Checklist

  • I can confirm that my changes are working as intended

@margaretcdeleon
margaretcdeleon marked this pull request as draft October 6, 2026 03:40
@margaretcdeleon
margaretcdeleon marked this pull request as ready for review October 6, 2026 03:41
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Autograder results

question status comment
Part 1 - Q1 ✅
Part 1 - Q2 ✅
Part 1 - Q3 ✅
Part 1 - Q4 ✅
Part 1 - Q5 ✅
Part 1 - Q6 ✅
Part 1 - Q7 ✅
Part 1 - Q8 ✅
Part 2 ❌ coworker-changes branch not found in commit history

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder checks failed. Please address the issues listed in the results comment.

@margaretcdeleon
margaretcdeleon merged commit 611d29a into main Oct 6, 2026
2 checks passed
@mbonsma

mbonsma commented Oct 8, 2026

Copy link
Copy Markdown

Hello Margaret, you're just missing part 2 - if you complete those steps and push another commit, we can mark this as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants