-
Notifications
You must be signed in to change notification settings - Fork 12
Extract parser into new @marko/parse package #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DylanPiercey
wants to merge
4
commits into
main
Choose a base branch
from
dpiercey-ws-eslint-wv2qux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
47d9673
Extract parser into new @marko/parse package
DylanPiercey 83e3308
Let the parse hook only override tag body types and write trailing bo…
DylanPiercey 23cdd68
Always give Static nodes a name range and carry trailing body comment…
DylanPiercey 9a9bcb1
Normalize the filename in the language tools parse wrapper
DylanPiercey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@marko/language-tools": major | ||
| --- | ||
|
|
||
| The parser now lives in (and is re-exported from) the new `@marko/parse` package. Breaking changes for consumers of the parser API: `NodeType` values are now strings rather than numbers, `program.body` now includes comment and static statement nodes in document order (`Node.ChildNode` includes `Comment`, and `program.body` is typed as `Node.RootBodyNode[]`), `Comment` nodes carry a `commentType`, and `Static` nodes carry `target`/`name`. Additions: `parse` accepts an options argument with a `getTagType` hook, the parse result exposes `errors` and a flat `comments` list, and the full `htmljs-parser` surface is re-exported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@marko/parse": minor | ||
| --- | ||
|
|
||
| New package: the Marko CST parser previously embedded in `@marko/language-tools`, extracted so it can be shared by other tooling. Node types are strings, syntax errors and comments are exposed on the parse result, comments and static statements are part of `program.body`, the filename is returned verbatim, and a `getTagType` option allows overriding how tag bodies parse (the built in statement and attribute tag node kinds are decided first; the hook only overrides a tag's body type or forces a generic `Static` statement). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep this changeset at a major release.
NodeTypevalues changed from numbers to strings, and@marko/language-toolsre-exports this API. Existing consumers can break when they receive strings where they expect numbers. Change the release level back tomajor.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents