Skip to content

Drive the parser from the @marko/parse CST #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DylanPiercey wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Drive the parser from the @marko/parse CST #3769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bcd625
Drive compiler parser from the @marko/parse CST
DylanPiercey Aug 6, 2026
c0a7810
Handle the parser's built in statement nodes in the compiler
DylanPiercey Sep 2, 2026
f301789
Use the Static node's name range for the statement keyword
DylanPiercey Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cst-parser.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@marko/compiler": patch
---

Drive the parser from the `@marko/parse` syntax tree instead of raw `htmljs-parser` events.
2 changes: 1 addition & 1 deletion packages/compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
},
"dependencies": {
"@luxass/strip-json-comments": "^2.0.1",
"@marko/parse": "link:../../../language-server/packages/parse",

@coderabbitai coderabbitai Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick win

Replace the link: dependency with a published version range before merge.

link:../../../language-server/packages/parse resolves outside this repository. Installs fail for anyone without that sibling checkout, and a published @marko/compiler tarball would carry an unresolvable dependency. The PR description already flags this as a pre-merge requirement.

🔧 Proposed change once `@marko/parse` is published 
-    "`@marko/parse`": "link:../../../language-server/packages/parse",
+    "`@marko/parse`": "^<published-version>",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/compiler/package.json` at line 74, Replace the `@marko/parse`
dependency in packages/compiler/package.json with the appropriate published
version range, removing the link: path so installs and published tarballs
resolve without a sibling checkout.

"complain": "^1.6.1",
"htmljs-parser": "^5.14.0",
"jsesc": "^3.1.0",
"kleur": "^4.1.5",
"lasso-package-root": "^1.0.1",
Expand Down
Loading
Loading