Repository navigation
fix!: wire up or remove config keys nothing reads - #520
Merged
Merged
Conversation
- admin-panel.page_title: DashboardController now injects AdminPanelConfigInterface and passes getPageTitle() to the template as pageTitle, which the latte/twig base layouts already render in <title>. - admin-panel.items_per_page / getItemsPerPage(): removed. The panel has no listing to paginate. - layout.components / layout.layouts: removed along with config/layout.php. Layouts and components are discovered from attributes. - mail.sendmail: removed. No sendmail driver ships; the driver comment now names the drivers that do (smtp, log). The matching ConfigReadersTest allowlist entries are gone, and the docs and tutorial no longer mention the removed keys. Fixes #518 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KyjR4cJTfro54iFZ9CWkv1
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin-panel.page_title: now wired up.DashboardControllerinjectsAdminPanelConfigInterfaceand passesgetPageTitle()toadmin-panel::dashboard/indexaspageTitle. The latte and twig base layouts already render it in<title>; until now they always fell back to their hard-coded default.admin-panel.items_per_page/AdminPanelConfig(Interface)::getItemsPerPage(): removed. The panel has no listing to paginate.layout.components/layout.layouts: removed, along withpackages/layout/config/layout.php(they were its only keys). Layouts and components are discovered from attributes.mail.sendmail: removed. No sendmail driver ships. Thedrivercomment now names the drivers that do ship (smtpvia marko/mail-smtp,logvia marko/mail-log); it used to listsendmailandarray, which don't exist.tests/config-readers-allowlist.php, and dropped the removed keys from the admin-panel docs page and the build-an-admin-panel tutorial. Added a Configuration section forpage_titleto the docs.Breaking
AdminPanelConfigInterface::getItemsPerPage()is gone. App code that called it, or a Preference that implements the interface, has to drop that method. Apps that need a page size should read their own config key.DashboardControllerhas a new constructor argument (AdminPanelConfigInterface $config). Autowiring handles it; a subclass or a manualnewmust pass it.config/layout.phpand themail.sendmailblock no longer ship. App-level overrides of those keys are harmless; they were never read.Test plan
DashboardControllerTest: a new test proves the configuredadmin-panel.page_titlereaches the template aspageTitleAdminPanelConfigTestchecks that the shipped config holds onlypage_titlePackageStructureTestchecks that the package ships no config directoryConfigReadersTestpasses without the five allowlist entriescomposer test,cs:checkandphpstanall green locallyNotes
LoginControllerwas out of scope for this PR because Admin failed-login re-render omits csrfToken, so the second login attempt fails CSRF #511 is changing it in parallel. Its template still uses its own default (Login - Marko Admin).Fixes #518
🤖 Generated with Claude Code
https://claude.ai/code/session_01KyjR4cJTfro54iFZ9CWkv1