Repository navigation
Fix quickstart: correct agent_data placement and add model adapter implementation - #70
Merged
Merged
Conversation
…rt: agent_data goes to .run(), not constructor Updated the quickstart guide to include configuration of model IDs and use of a custom benchmark class.
cemde
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the quickstart guide to include configuration of model IDs and use of a custom benchmark class.
Description
While following the quickstart guide with a fresh
maseval[openai]install (v0.5.1), the "Using a default agent" and "Plugging in your own agent" examples under Existing Benchmarks did not run as written:DefaultAgentTau2Benchmarkcannot be instantiated directly sinceget_model_adapteris abstract — the example needs a subclass implementing it.agent_datais not accepted by theTau2Benchmarkconstructor; it belongs in.run(tasks, agent_data=...).model_idmust be set viaconfigure_model_ids()afterload_tasks(), or.run()raises aValueError.This PR updates both code examples to reflect the current API, verified against a real run.
Type of Change
Checklist
Contribution
Documentation
docs/(if applicable)Changelog
CHANGELOG.mdunder[Unreleased]sectionArchitecture (if applicable)
maseval/core/do NOT import frommaseval/interface/Additional Notes
Only fixed the two
Tau2Benchmark-based examples, which I tested end-to-end. Did not touch the genericMyBenchmark(Benchmark)example at the top of the page since I haven't verified whether the baseBenchmarkclass has the sameagent_datasignature issue — flagging in case a maintainer wants to check that separately.