Prevent alert bursts after Mac sleep - #23
Merged
Merged
Conversation
Observe macOS system sleep and wake events. Stop active sounds before sleep, rebuild the audio engine on wake, and discard background chimes for five seconds while timelines catch up. Block new sounds immediately when power commands arrive, including while older timeline callbacks are still queued. Keep engine access on the core loop and keep the gate closed until all pending power commands finish. Route automatic timeline and notification chimes through a shared policy that allows one background chime at a time, at least one second apart. Action sounds such as boosting, liking, and posting remain independent and can still overlap incoming-post chimes after wake recovery. Add regression coverage for wake suppression, repeated power transitions, short notification bursts, and long soundpack clips. Register the tests in the test runner and Windows build, and add the 0.5.9 changelog entry. Validation: macOS app and core builds succeeded; 1,439 checks passed. Actual sleep/wake behavior with live accounts still needs a manual run. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Waking a Mac could play overlapping timeline and notification sounds together, producing a loud burst. The Mac client now stops sounds for system sleep, rebuilds audio on wake, and discards background chimes for five seconds while timelines catch up.
Validation
git diff --checkpassed.A real sleep/wake cycle with live accounts and an audio device still needs manual verification. Other front ends were not built locally.