Repository navigation
feature/SOF-8065 Feature: SE for graphene on SiO2, doping and gap at the Dirac point #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VsevolodX
wants to merge
18
commits into
main
Choose a base branch
from
feature/SOF-8065
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8d92c93
SOF-8065: graphene/SiO2 metastable registry, back passivation, simula…
VsevolodX 594e4f4
SOF-8065: structure notebook as on main plus the import fix; one-mate…
VsevolodX 12b67d2
SOF-8065: clear atom labels after load; read the Dirac pair by band i…
VsevolodX 6c8a0aa
SOF-8065: TIME_LIMIT 04:00:00 as the sibling notebooks ship
VsevolodX 801ccd2
SOF-8065: substrate thickness 5 and vacuum about 20 A above graphene
VsevolodX 0b5e82b
SOF-8065: review round 1 fixes in the simulation and structure notebooks
VsevolodX c885310
SOF-8065: cell reset in the structure notebook, band path and smearin…
VsevolodX e1e3816
SOF-8065: re-review fixes (names, markdown, thickness comment)
VsevolodX c06e072
SOF-8065: 8.2 markdown wording
VsevolodX 604f21a
SOF-8065: markdown nits in 8.2 and 3.5
VsevolodX 1c3af46
SOF-8065: rev 4 - metastable registry shift, relaxation default, valu…
VsevolodX 6cd5545
SOF-8065: one time limit for both jobs
VsevolodX d9968a8
SOF-8065: center the slab along z
VsevolodX 399dcda
SOF-8065: coarser relaxation k-mesh and a fixed deep substrate
VsevolodX c57844f
SOF-8065: relaxation in the same job through add_relaxation
VsevolodX ae1e1b7
SOF-8065: relaxation on the same k-mesh, all atoms free, RELAX False …
VsevolodX a2be5a3
SOF-8065: review fixes - structure comments and heading, one relaxati…
VsevolodX 13607b1
SOF-8065: keep code lines under 120 characters
VsevolodX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Verify that the HEX relabel matches the transformed cell.
The notebook applies
supercell_matrix=[[1, 0, 0], [-1, 1, 0], [0, 0, 1]]and then setsinterface.lattice.type = "HEX". The text states that this gives γ = 120°. The code only prints γ after the step. It does not assert γ ≈ 120° or a = b.If the interface cell differs from the expected one, for example for a different
selected_indexorMAX_AREA, the label is wrong. The simulation notebook then builds a K point for a non-hexagonal cell.Add an assertion after the relabel.
Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents