Skip to content

feature/SOF-8050 Feature: hysteresis_loop property [AI-written] - #52

Closed
VsevolodX wants to merge 9 commits into
mainfrom
feature/SOF-8050
Closed

VsevolodX wants to merge 9 commits into
mainfrom
feature/SOF-8050

Conversation

@VsevolodX

Copy link
Copy Markdown
Member

A hysteresis_loop property class: on/off-field response curves with loop parameters (mean and spread over repeated loops).

Commits

  • 1dcffb2 fix(SOF-8050): hysteresis loop series named from field_condition, not raw schema values
  • 138816a chore(SOF-8050): regenerate mixin for the loop property review round
  • 0a6739f fix(SOF-8050): hysteresis loop chart shows its legend — on and off series were indistinguishable
  • c463f33 feat(SOF-8050): hysteresis loop property carries its parameters; loop scalar classes removed
  • 91c846f fix(SOF-8050): hysteresis loop axis labels from the schema; scalar tests assert isRefined
  • 92a7fc8 feat(SOF-8050): property classes for hysteresis_loop and the five loop scalars

Plan and decisions: SOF-8050 (planning repo, tasks/SOF-8050-alphafilm-experimental-data).

🤖 Generated with Claude Code

VsevolodX and others added 9 commits September 4, 2026 10:39
…p scalars

Six properties added in ESSE (SOF-8050) had no class in prode, so
PropertyFactory.createProperty threw for every stored measurement
property and the web-app rendered blank rows.

ImprintProperty, CoerciveVoltageProperty, LoopWidthProperty,
LoopHeightProperty and RemanentResponseProperty are copies of
properties/scalar/PressureProperty.ts; HysteresisLoopProperty is a copy
of properties/non-scalar/ReactionEnergyProfileProperty.ts with the bias
axis titles. Tests follow properties/fermi_energy.test.ts and, for the
loop, properties/average_potential_profile.test.ts.

Built against ESSE feature/SOF-8050 @ 848f200e1 (local tarball, pin not
committed); the six generated mixins come from npm run generate-mixins
and no other generated file changed.
…sts assert isRefined

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… scalar classes removed

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ries were indistinguishable

The shared 2D-plot mixin disables the legend box; the loop overrides it as DensityOfStatesConfig does.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… raw schema values

seriesNames replaces legends (the schema's legend array no longer doubles as the
2D-plot mixin's legend-box toggle); the on/off series are labelled On-field/Off-field
per field_condition.json, guarded so a short legend cannot yield name: undefined.
Test loads the esse example instead of a hand-copied fixture.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@VsevolodX

Copy link
Copy Markdown
Member Author

Closing: feature/SOF-8050 becomes the epic branch for SOF-8050, recreated from main. This experiment is kept unchanged at feature/SOF-8050-experiment (fb5d24c). The clean work is #53, which now targets feature/SOF-8050.

@VsevolodX VsevolodX closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant