Skip to content

Metric 20260629#2010

Open
affeldt-aist wants to merge 4 commits into
math-comp:masterfrom
affeldt-aist:metric_20260629
Open

Metric 20260629#2010
affeldt-aist wants to merge 4 commits into
math-comp:masterfrom
affeldt-aist:metric_20260629

Conversation

@affeldt-aist

Copy link
Copy Markdown
Member
Motivation for this change

fyi: @mkerjean @Brixfoly @hoheinzollern

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist

Copy link
Copy Markdown
Member Author

What is the right syntax for empty factories?
The CI output is indicating two syntaxes:

       > ROCQ compile theories/normedtype_theory/normed_module.v
       > File "./theories/normedtype_theory/normed_module.v", line 103, characters 0-83:
       > Error:
       > Usage: HB.factory Record <FactoryName> T & F A & … := { … }.
       > Usage: HB.factory Definition <FactoryName> T of F A := t.

We used the first one and it does not fail locally.
@Brixfoly @hoheinzollern

@affeldt-aist

Copy link
Copy Markdown
Member Author

Ah, found the problem: the "of" now must be an &!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant