Skip to content

refactor(interactive-example): use fixed heading IDs - #1924

Merged
LeoMcA merged 1 commit into
mainfrom
913-fix-interactive-example-heading-ids
Sep 23, 2026
Merged

LeoMcA merged 1 commit into
mainfrom
913-fix-interactive-example-heading-ids

Conversation

@caugner

@caugner caugner commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

Replace generated interactive-example heading IDs with fixed IDs scoped to each custom element's shadow root.

Motivation

Avoid generating random IDs where shadow-root scoping already guarantees uniqueness.

Additional details

Each template variant uses a distinct ID: ix-choices, ix-console, or ix-tabbed. InteractiveExampleBase opts out of SSR, so this does not affect generated build output.

Related issues and pull requests

Related to #913.
Related to #936.

@github-actions

Copy link
Copy Markdown
Contributor

a9c3abc was deployed to: https://fred-pr1924.review.mdn.allizom.net/

@caugner
caugner marked this pull request as ready for review September 17, 2026 19:39
@caugner
caugner requested a review from a team as a code owner September 17, 2026 19:39
@caugner
caugner requested a review from LeoMcA September 17, 2026 19:39
@LeoMcA
LeoMcA merged commit d90b5b0 into main Sep 23, 2026
14 checks passed
@LeoMcA
LeoMcA deleted the 913-fix-interactive-example-heading-ids branch September 23, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants