Conversation
ewu63
force-pushed
the
ci-macos-arm64
branch
from
September 9, 2026 04:33
aec7584 to
23d76d4
Compare
ewu63
marked this pull request as ready for review
September 9, 2026 04:34
ewu63
force-pushed
the
ci-macos-arm64
branch
from
September 9, 2026 04:37
23d76d4 to
01532c3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 54.22% 54.22%
=======================================
Files 1 1
Lines 225 225
=======================================
Hits 122 122
Misses 103 103 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marcomangano
approved these changes
Sep 9, 2026
marcomangano
left a comment
Collaborator
There was a problem hiding this comment.
Not sure if the file deletion/creation was intentional or not, but I don't see an issue in losing the git history for that .yml file.
Collaborator
Author
I believe the rename is preserved, see here for example |
Collaborator
|
Oh nice, all good then |
marcomangano
approved these changes
Sep 10, 2026
Collaborator
Author
|
@A-CGray can I get a second review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add MacOS arm64 builds to GHA.
Expected time until merged
No rush
Type of change
Testing
Checklist
ruff checkandruff formatto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable