Skip to content

Remove stories_by_source_week in next (major?) release? #126

Description

@philbudne

V5 CHANGELOG said:

Depreciate stores_by_source_week [SIC] 2d aggregation endpoint, replace with stories_by_source_over_interval

AND/BUT the necessary backend endpoint is gone, but the API method remained in this library? A major release is free to make breaking changes, so perhaps this was an oversight?

The backend (web-search) endpoint for the older call is gone breaking backwards compatibility, tho not a big deal, since the only external user observed to have used the old endpoint wasn't using this library.

Since it's tempting to make a major release when api-params from the server are honored (to increase uptake, since the change doesn't effect the visible API), maybe remove the now dead call at the same time??

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions