Skip to content

Handle responses without (or with bad) JSON data #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philbudne merged 1 commit into from
Aug 18, 2026
Merged

Handle responses without (or with bad) JSON data #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions mediacloud/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,30 @@ def _query(self, endpoint: str, params: Optional[Dict] = None, method: str = 'GE
r = self._session.patch(endpoint_url, json=params, timeout=self.TIMEOUT_SECS)
else:
raise RuntimeError(f"Unsupported method of '{method}'")
if r.status_code // 100 != 2: # create operations return 201
raise mediacloud.error.APIResponseError(r, params, r.json())

return r.json()
status_class = r.status_code // 100
if r.text:
try:
j = r.json()
except:
# here with non/bad json response
j = {
"status": "bad-response",
"note": f"bad JSON: {r.text}" # for APIResponseError
}
status_class = 99
else:
# Here with 429 error from older servers
j = {
"status": "empty",
"note": "empty-response" # for APIResponseError
}
status_class = 99

if status_class != 2: # create operations return 201
raise mediacloud.error.APIResponseError(r, params, j)

return j


class DirectoryApi(BaseApi):
Expand Down
Loading