Yet more unit test fixes - #114
Merged
Merged
Conversation
rahulbot
marked this pull request as ready for review
August 26, 2026 14:00
philbudne
approved these changes
Aug 30, 2026
philbudne
left a comment
philbudne
left a comment
Contributor
There was a problem hiding this comment.
FWIW: I don't know of any code that uses the library's ability to fetch pages!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since wayback machine is down again I finally bit the bullet and changed more of our unit tests to be run from static fixtures. Honestly that makes them more like unit tests and not integration tests. Plus this should make transient failures due to network issues irrelevant. On the flip side, it does make our CI testing slightly less resilient, since it doesn't actually try to fetch very much live from the web.