Repository navigation
feat(map): AR mesh view - #7659
Draft
jamesarich wants to merge 14 commits into
Draft
jamesarich wants to merge 14 commits into
jamesarich wants to merge 14 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The map's node filters become a plain NodeMapFilter predicate over Node, so a view outside feature:map can apply the same rules. MapNodePolicy delegates to it, and MapFilterPrefs converts to it directly.
…to core The compass's phone location and declination providers become core:repository interfaces with their Android implementations in core:data, so a view outside feature:node can read the phone's fix and true north the same way.
Point the back camera at the horizon and see the mesh in place: nodes as their chips and waypoints as their emoji, by bearing and elevation, over a CameraX preview. It opens from the map for everything in range, from node detail and the compass for one node, from a traceroute's map to draw that route in the air, and from the position log to draw that node's track. The pose is the rotation vector's camera axes, smoothed with a 1€ filter, and the field of view comes from the lens calibration and the stream crop. Elevation compares altitudes in one frame. Precision draws as a fading zone from both positions' accuracy and the heading error. The phone's own fix is averaged while it is still and shown live, and targets too close to point at go on a heading-up radar. Off-screen targets pin to the edge to turn or tilt toward, a focused target gets a reticle, a turn hint and a haptic lock, and dragging the view corrects the compass. Traceroutes draw as lifted arcs, forward up and return down, weighted by each link's SNR; tracks as breadcrumbs fading with age; geofences as walls on the ground. It follows the map's filters and a range toggle. The compass shares the mesh view's position uncertainty and fix time rules.
From node detail or the compass the view shows that node alone; from the position log, that node and its track; from a traceroute, its destination and hops. Waypoints, geofences, other nodes and the range toggle stay out. Opened from the map it still shows everything the filters allow.
A scoped view whose nodes all sit inside their own uncertainty showed only radar dots, so a traceroute or track looked empty. The radar now draws both in plan view, and a node with no live position takes the one its route or track recorded. The view no longer reports an empty mesh before its first update. Also: the return leg's stem from the viewer, scoped views ignore the range limit, AltitudeConverterCompat for sea level altitude, the geofence foot line clipped at the near plane, and an "Open waypoint" click label.
…er stacks on itself
…with sensor fallbacks and thermal backoff
jamesarich
force-pushed
the
feat/mesh-view
branch
from
October 20, 2026 02:22
3323ef4 to
2b8e81d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding a node on foot means flipping between the map and the compass. This adds a camera mesh view: point the phone at the horizon and see nodes, waypoints, traceroutes and tracks where they actually are, with how sure each position is.
🌟 New Features
feature/map/.../hud), opened from the map's top bar, a node's position section and compass sheet, the node list's long-press menu, a traceroute's map, and the position log. The node list menu also gains Open Compass.googlecomes from the Fused Orientation Provider, with its live heading error;fdroidand phones without Play services use the rotation vector, then the geomagnetic rotation vector on phones with no gyroscope.🛠️ Refactoring & Architecture
feature:maptocore:model(NodeMapFilter);MapNodePolicydelegates to it.PhoneLocationProviderandMagneticFieldProvidermove fromfeature:nodetocore:repository, their Android implementations tocore:data.core:modelPositionPrecision).rememberMeshHudSupported()incore:ui;MapRoute.MeshHudroute;NodesRoute.NodeDetail(openCompass);MapPrefs.meshHudCoachSeen.FusedOrientationSourcebound per flavor, soAndroidCameraPoseProviderstays the one pose provider.center_focus_strong;view_in_arstays with the 3D model viewer in feat(node): view a device's 3D model, and place it in AR on the google flavor #7639.Deferred: the ARCore Geospatial API (Cloud project, privacy text, camera frames to Google, no F-Droid), adding
FUSED_PROVIDERto the phone's location request until it is measured against the compass jitter fix, and a "Find" action on the map, which has no node info window to hold one.Testing Performed
HudGeometryTest,HudTargetsTest,HudPathsTest,HudRadarTest,HudEdgesTest,HudChipsTest,FixAveragerTest,OneEuroQuaternionFilterTest,MeshHudViewModelTest,DeviceAttitudeTest,MeshHudBackStackTest;MapRoute.MeshHudround trip inNavigationConfigTest.-PwarningsAsErrors=true(spotless, detekt, detektTypeResolved, assembleDebug, test, allTests, kmpSmokeCompile).