Repository navigation
build(flatpak): stamp the overlay's Gradle zip from the wrapper - #7681
Conversation
Renovate can bump the vendored Gradle URL in desktop-offline.yaml but not its sha256, so every wrapper bump left verify-flatpak red until someone copied distributionSha256Sum by hand. verify.sh and verify-flatpak.yml now fill the URL and sha256 into their copy of the overlay with bump-flathub-manifest.py --gradle-only, which drops the Renovate custom manager and the mismatch guard.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Regression Coverage For Changed Behavior |  |
Regression coverage is missing for the new Flatpak stamping behavior. bump-flathub-manifest.py adds the --gradle-only branch and changes the normal-mode argument path (lines 53-76), while `verify.… |
Add an automated Python test for bump-flathub-manifest.py using temporary wrapper and manifest fixtures. Assert that --gradle-only replaces the Gradle URL and SHA-256, preserves the Git tag and commit, and is idempotent. Assert that inv… |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: deriving the Flatpak overlay Gradle ZIP from the Gradle wrapper. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Sibling Call Sites And Presence Semantics PASS. The diff changes Flatpak Gradle manifest handling only. It does not change nullable or zero-guard semantics for RSSI, temperature, current, voltage, particulate concentration, humidity, or app-l… Tests Prove The Path, Not The End State No tests were added or changed in the pull request. The changed files are workflow, configuration, documentation, shell, YAML, and Python production code, so the custom test-path conditions do not app… Moved Code Diffed Against Its Original The check is not applicable. The PR has no renames or extracted modules, and it does not delete a type or function and add it elsewhere. bump-flathub-manifest.pyretainswrapper_distribution, `rep…Full details: Sibling Call Sites And Presence Semantics
-
Explanation
PASS. The diff changes Flatpak Gradle manifest handling only. It does not change nullable or zero-guard semantics for RSSI, temperature, current, voltage, particulate concentration, humidity, or app-level SNR fields. The all-zero value is a Gradle SHA-256 placeholder, not a physical measurement default. Both changed consumers invoke
bump-flathub-manifest.py --gradle-only; no unfixed sensor sibling call site exists in the reviewed range.
Full details: Tests Prove The Path, Not The End State
-
Explanation
No tests were added or changed in the pull request. The changed files are workflow, configuration, documentation, shell, YAML, and Python production code, so the custom test-path conditions do not apply.
Full details: Moved Code Diffed Against Its Original
-
Explanation
The check is not applicable. The PR has no renames or extracted modules, and it does not delete a type or function and add it elsewhere.
bump-flathub-manifest.pyretainswrapper_distribution,replace_once, andmain; the changes add a--gradle-onlybranch. The removed shell guard is replaced by a new script invocation, not moved code.
-
Full details: Regression Coverage For Changed Behavior
-
Explanation
Regression coverage is missing for the new Flatpak stamping behavior.
bump-flathub-manifest.pyadds the--gradle-onlybranch and changes the normal-mode argument path (lines 53-76), whileverify.shandverify-flatpak.ymlnow stamp copied manifests (verify.sh lines 109-112; workflow lines 101-105). The diff adds no tests, and the repository has no test that exercises this helper. The existing Flatpak build checks the final artifact, but it does not verify that Gradle-only mode preserves the Git source fields, is idempotent, or rejects malformed and duplicate inputs. Full mode also has no regression test despite the argument-handling change.Resolution
Add an automated Python test for
bump-flathub-manifest.pyusing temporary wrapper and manifest fixtures. Assert that--gradle-onlyreplaces the Gradle URL and SHA-256, preserves the Git tag and commit, and is idempotent. Assert that invalid wrapper values and missing or duplicate manifest matches fail. Add a full-mode case to prove the existing Git-source rewrite still works. Add a lightweight wiring test or CI smoke fixture that runs theverify.shand workflow stamping commands against a copied overlay and asserts that no placeholder URL or zero SHA-256 reaches the build.
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
1 participant
Renovate can bump the vendored Gradle URL in the flatpak overlay but not its sha256, so every wrapper bump leaves
Verify Flatpak Offline Buildred until someone copiesdistributionSha256Sumby hand (#7574, #7677). The overlay now holds a placeholder and both consumers fill it from the wrapper, so there is nothing left to bump.🛠️ Refactoring & Architecture
bump-flathub-manifest.py --gradle-onlyrewrites just the Gradle zip url and sha256 fromgradle-wrapper.properties.verify-flatpak.ymlandverify.shrun it on their copy ofdesktop-offline.yaml.🧹 Chores
Testing Performed
--gradle-onlyon a copy of the overlay yieldsgradle-9.8.2-bin.zipwith the wrapper's sha256, and is idempotent.jq empty .github/renovate.jsonpass.Summary by CodeRabbit