Skip to content

feat(variants): Define OCV_ARRAY in Seeed Wio Tracker L1 / L1 Pro (non e-ink / non-1W variant) - #11986

Open
t-miura wants to merge 2 commits into
meshtastic:developfrom
t-miura:feat/seeed-l1-pro-ocv-curve
Open

t-miura wants to merge 2 commits into
meshtastic:developfrom
t-miura:feat/seeed-l1-pro-ocv-curve

Conversation

@t-miura

@t-miura t-miura commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This backports Wio Tracker L1 e-ink variant's OCV_ARRAY into non e-ink Wio Tracker L1 Pro(seeed_wio_tracker_L1 variant).

Details / Backgrounds

On previous PR #7194 , OCV_ARRAY for SEEED_WIO_TRACKER_L1 was applied to all non-1W variant:

  • OLED ( L1 & L1 Pro )
  • E-Ink ( L1 E-Ink )
  • (possibly) No Display ( L1 Lite, L1 Pro variant could be used as absent of OLED is the only difference)

as it was defined in src/power.h and both variant defines SEEED_WIO_TRACKER_L1 in their variant.h.

Current develop branch now defines OCV_ARRAY in per-variant fashion, OCV_ARRAY only exists in e-ink variant.

This backports e-ink variant's OCV_ARRAY into non e-ink Wio Tracker L1 / L1 Pro.

Note: L1 Pro 1W version requires/uses its own OCV_ARRAY: #11972

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck (Plus, Internal Antenna)
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)
      • Seeed Studio Wio Tracker L1 Pro

Summary by CodeRabbit

  • Improvements
    • Battery charge-level readings on the Seeed Wio Tracker L1 now use a voltage profile specific to the device.

On previous PR 7194, `OCV_ARRAY` for SEEED_WIO_TRACKER_L1 was applied to both non e-ink(aka L1 Pro/OLED) and e-ink variant,
as it was defined in src/power.h and both variant defines `SEEED_WIO_TRACKER_L1` in variant.h.
Meanwhile, official repos defines `OCV_ARRAY` per-variant fashion, thus no OCV_ARRAY definition in `seeed_wio_tracker_L1`.

This backports e-ink variant's `OCV_ARRAY` into non e-ink Wio Tracker L1 Pro.
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: meshtastic/firmware/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c738fae4-4e43-4443-baa7-6b9449434b10

📥 Commits

Reviewing files that changed from the base of the PR and between d630775 and 211bdf6.

📒 Files selected for processing (1)
  • variants/nrf52840/seeed_wio_tracker_L1/variant.h

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The Seeed Wio Tracker L1 variant header adds an OCV_ARRAY macro with eleven voltage values. A comment notes that the array is shared with the E-Ink variant and that the 1W variant uses a separate array.

Changes

Wio Tracker L1 OCV Array

Layer / File(s) Summary
Define the OCV array
variants/nrf52840/seeed_wio_tracker_L1/variant.h
Adds OCV_ARRAY with eleven voltage values and a comment describing its relationship to the E-Ink and 1W variants.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: jp-bennett

Merge Risk: ⚪ Minimal · up to 211bd

The L1 variant now has the expected 11-point voltage table, matching the E-Ink curve. No concrete merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 211bd

The change affects 1 system.

Changed systems: variants

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — variants (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in variants/nrf52840/seeed_wio_tracker_L1/variant.h: Adds the OCV_ARRAY macro with eleven values and a comment describing its relationship to the E-Ink and 1W variants.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the addition of OCV_ARRAY for the non-e-ink, non-1W Seeed Wio Tracker L1 and L1 Pro variants.
Description check ✅ Passed The description explains the motivation, scope, variant distinctions, related PR, and test results. The required attestations are completed for the reported tests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@t-miura
t-miura marked this pull request as ready for review September 27, 2026 07:30
@t-miura t-miura changed the title feat(power): Define OCV_ARRAY in Seeed Wio Tracker L1 / L1 Pro (non e-ink / non-1W variant) feat(variants): Define OCV_ARRAY in Seeed Wio Tracker L1 / L1 Pro (non e-ink / non-1W variant) Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant