Repository navigation
feat(variants): Define OCV_ARRAY in Seeed Wio Tracker L1 / L1 Pro (non e-ink / non-1W variant) - #11986
feat(variants): Define OCV_ARRAY in Seeed Wio Tracker L1 / L1 Pro (non e-ink / non-1W variant)#11986t-miura wants to merge 2 commits into
Conversation
On previous PR 7194, `OCV_ARRAY` for SEEED_WIO_TRACKER_L1 was applied to both non e-ink(aka L1 Pro/OLED) and e-ink variant, as it was defined in src/power.h and both variant defines `SEEED_WIO_TRACKER_L1` in variant.h. Meanwhile, official repos defines `OCV_ARRAY` per-variant fashion, thus no OCV_ARRAY definition in `seeed_wio_tracker_L1`. This backports e-ink variant's `OCV_ARRAY` into non e-ink Wio Tracker L1 Pro.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: meshtastic/firmware/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Seeed Wio Tracker L1 variant header adds an ChangesWio Tracker L1 OCV Array
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The L1 variant now has the expected 11-point voltage table, matching the E-Ink curve. No concrete merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
Summary
This backports Wio Tracker L1 e-ink variant's
OCV_ARRAYinto non e-ink Wio Tracker L1 Pro(seeed_wio_tracker_L1variant).Details / Backgrounds
On previous PR #7194 ,
OCV_ARRAYfor SEEED_WIO_TRACKER_L1 was applied to all non-1W variant:as it was defined in src/power.h and both variant defines
SEEED_WIO_TRACKER_L1in their variant.h.Current
developbranch now definesOCV_ARRAYin per-variant fashion,OCV_ARRAYonly exists in e-ink variant.This backports e-ink variant's
OCV_ARRAYinto non e-ink Wio Tracker L1 / L1 Pro.Note: L1 Pro 1W version requires/uses its own OCV_ARRAY: #11972
🤝 Attestations
Summary by CodeRabbit