[oscgonfer]

This Pull request aims to have a clean AirQualityTelemetry module, decoupled from the PMSA003I sensor integration, and update to the latest changes in master.

It already contains the work by @fifieldt on #7187. Other efforts have been done as part of other sensor integrations such as this #4601 for the CO2 sensor SCD4X (in this commit 318da22) or in this other https://github.com/hafu/meshtastic-firmware/tree/add-scd30 to add a SCD30 (in this commit 735b428).

I open a separate one to be able to test this features separately, and create other branches separate to integrate those sensors (and others as part of the hackathon). The features to test are:

• Check this is the right implementation of the readings for this particular PMS sensor
• Check the logic to send to sleep and wake up the sensor. This is not added in other PRs and it's critical for sensors that have such high consumption as the PM sensors, which draw +200mA or more on boot
• Check the rescan logic originally implemented as part of the AirQualityTelemetry class, I assume for those sensors that have a long boot time
• Check that this all works with the recent screen changes

Sadly, I don't have a PMSA003I sensor with me at the moment (I have ordered one), but if anyone has one, it'd be great if you can check and/or give feedback. I think the original implementer @thebentern and @fifieldt would have a lot to say. I'll try to be responsive to be able to fix.

NOTE: Since I am making a PR from a separate org github doesn't allow for edits (see this issue).

[Copilot]

Pull Request Overview

This PR decouples the PMSA003I sensor from the AirQualityTelemetryModule into its own class and brings the telemetry code up to date with master.

• Extracted PMSA003I logic into PMSA003ISensor
• Refactored AirQualityTelemetryModule to delegate sensor operations and add deep‐sleep support
• Cleaned up legacy fields and removed direct sensor handling from environmental telemetry

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/modules/Telemetry/Sensor/PMSA003ISensor.h	New sensor class declaration and warmup constant
src/modules/Telemetry/Sensor/PMSA003ISensor.cpp	New sensor class implementation and I2C scanning logic
src/modules/Telemetry/EnvironmentTelemetry.h	Removed unused sensor_read_error_count field
src/modules/Telemetry/EnvironmentTelemetry.cpp	Removed reset of sensor_read_error_count
src/modules/Telemetry/AirQualityTelemetry.h	Updated module to use PMSA003ISensor, UI stubs, and config
src/modules/Telemetry/AirQualityTelemetry.cpp	Refactored run/send logic, deep‐sleep integration, UI drawing
src/modules/Modules.cpp	Always register AirQualityTelemetryModule

Comments suppressed due to low confidence (7)

src/modules/Telemetry/Sensor/PMSA003ISensor.h:41

• The call to pinMode is placed at class scope, which is invalid C++; move it into the constructor or setup() method.

    pinMode(PMSA003I_ENABLE_PIN, OUTPUT);

src/modules/Telemetry/Sensor/PMSA003ISensor.cpp:54

• Definition of sleep() is missing the class scope qualifier; it should be defined as void PMSA003ISensor::sleep().

void sleep() {

src/modules/Telemetry/Sensor/PMSA003ISensor.cpp:59

• Definition of wakeUp() is missing the class scope qualifier and lacks a return statement; it should be uint32_t PMSA003ISensor::wakeUp() and return the warmup delay.

uint32_t wakeUp() {

src/modules/Telemetry/Sensor/PMSA003ISensor.cpp:68

• Typo in the log message: "AQIn" should be "AQI".

        LOG_WARN("Skip send measurements. Could not read AQIn");

src/modules/Telemetry/AirQualityTelemetry.cpp:29

• sleepOnNextExecution is used but not declared in AirQualityTelemetryModule; add a bool sleepOnNextExecution member.

    if (sleepOnNextExecution == true) {

src/modules/Telemetry/AirQualityTelemetry.cpp:77

• state is a private member of PMSA003ISensor and pmsa003iSensor::State::IDLE is invalid syntax; either expose a getter or use PMSA003ISensor::State::IDLE and adjust access.

        if (pmsa003iSensor.hasSensor() && pmsa003iSensor.state == pmsa003iSensor::State::IDLE)

src/modules/Modules.cpp:218

• [nitpick] Instantiating AirQualityTelemetryModule unconditionally may start the module without a sensor; consider guarding this with a sensor‐presence check.

        new AirQualityTelemetryModule();

[oscgonfer]

@thebentern I have fixed (I think) comments by copilot #7190 (review)

[oscgonfer]

Rebased on to master

[hafu]

I saw your PR and checked out, while compiling for different targets I came across some issues.

[oscgonfer]

Merged master and resolved @hafu comments.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ oscgonfer
❌ peterzqx
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[oscgonfer]

Reworked based on https://github.com/meshtastic/firmware/pull/8054/changes and tested with seeed-xiao-s3.

Also adds CAN_RECLOCK_I2C to build flags for esp32_common architecture as it's the only one that read and change I2C speed on demand, which many sensors require and that are not compatible with higher I2C bus speeds needed by the oled display. This last aspect is added on the TelemetrySensor class, with a logic to check on each architecture.

It needs meshtastic/protobufs#840

[oscgonfer]

Not sure where this part should go. Maybe in src/detect?

https://github.com/fablabbcn/smartcitizen-meshtastic/blob/0d420ebc26f526b2e06e8f77abd8b8e42e4c429f/src/modules/Telemetry/Sensor/TelemetrySensor.cpp#L10-L44

[thebentern]

Not sure where this part should go. Maybe in src/detect?

https://github.com/fablabbcn/smartcitizen-meshtastic/blob/0d420ebc26f526b2e06e8f77abd8b8e42e4c429f/src/modules/Telemetry/Sensor/TelemetrySensor.cpp#L10-L44

Sounds good to me

[oscgonfer]

All builds pass? Is this real life? 👀

[HarukiToreda]

The BME680 sensor no longer outputs data. Could it be related to this PR. Sensor shows on boot but data never shows either on the logs, phone app, or gets sent through the mesh. I do not have other type of sensor but this may affect others with IAQ.

[HarukiToreda]

ignore, looks like a different PR is responsible for it