Repository navigation
Conversation
Accept canonical protobuf field names and JSON names while retaining legacy camel-to-snake lookup compatibility. Fix the use12hClock profile round trip, share name resolution with CLI reads and writes, and keep nested assignments on the current submessage. Reject unknown YAML profile keys and failed assignments before starting configuration writes. Preserve supported aliases, update shipped examples, and provide consistent confirmations and original-input lookup errors. Add offline regression coverage for imports, exports, CLI field aliases, examples, nested paths, channel settings, and validation failures.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Exporting a configuration with the 12-hour clock enabled produces
display.use12hClock: true. Reimporting that YAML currently converts the name touse12h_clockinstead ofuse_12h_clock, silently omitting the setting.Resolve configuration names using protobuf descriptors, accepting both canonical field names and JSON names while preserving previously accepted spellings through the existing conversion fallback. Share this lookup across YAML imports,
--set,--get, and--ch-set. Also correct nested setter traversal, make assignment confirmations consistent, and preserve the original query in unknown-field errors.YAML imports now reject unknown top-level keys, unknown configuration fields, and failed assignments before starting a settings transaction. Existing aliases remain supported. Profiles containing obsolete fields or extra metadata will now fail instead of silently skipping those entries. Update both shipped examples and add tests that import their actual contents.
Validation:
2.8.2.a2a27f4.This change does not address existing value-conversion failures or failures encountered while writing otherwise valid profiles to the device.
Summary by CodeRabbit