Repository navigation
ci(release-web): pin Node 24 instead of reading .nvmrc - #1477
Merged
danditomaso merged 1 commit intoOct 18, 2026
Merged
Conversation
release-web checks out inputs.ref, which can be a revision from before .nvmrc was added in meshtastic#1475, and setup-node fails when the file is missing. Raised by CodeRabbit on meshtastic#1475.
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #1475, from CodeRabbit's review there.
release-web.ymlchecks outinputs.ref, which can be any branch, tag or SHA, including one from before.nvmrcexisted.setup-nodefails whennode-version-filepoints at a missing file, so this workflow pinsnode-version: 24directly. The other workflows always build the commit that triggered them, so they keep reading.nvmrc.Related Issues
Follows #1475.
Changes Made
release-web.yml:node-version: 24instead ofnode-version-file: .nvmrc, with a comment explaining whyTesting Done
Not run. A
workflow_dispatchagainst an old tag would exercise it.Checklist