ENH: implement support for build-details.json (PEP 739) (continued)#829
ENH: implement support for build-details.json (PEP 739) (continued)#829mgorny wants to merge 2 commits into
Conversation
|
I closed gh-779. Copying over the main comment from that PR discussion: Good point. Yes, there isn't any reason that So for now in this PR we can distinguish three cases, with the user passing:
I focused on (3) first and have a TODO in here already to add (1); I should add (2) as well. |
dnicolodi
left a comment
There was a problem hiding this comment.
I had a quick look at this. Found some possible improvements.
|
I'm going to rebase it now, and make changes later when I find more time. |
f22d77f to
7758d1c
Compare
|
Updated and rebased now. |
3e48d47 to
bba067e
Compare
|
I tied up some loose ends. I think this is ready to be merged now. @rgommers, do you want to take a look? It would be nice to have an integration test for this, but I don't know how hard it is to get a suitable environment setup on GitHub Actions. |
|
Actually, I think it was in Draft because we wanted to make an integration test, but we were blocked on |
|
Sounds great! Indeed, that integration test would be nice. IIRC conda-forge/python-feedstock#858 should have solved the one issue in conda-forge that was blocking for a cross-compile test. |
d683af1 to
3fe11bd
Compare
There was a problem hiding this comment.
This still uses _32_BIT_INTERPRETER as determined from the running interpreter and not from build-details.toml.
There was a problem hiding this comment.
Ok, disabled it when using build details. I suppose it's fine to assume that if you're configuring cross via build-details.json, you'd be targeting the bitness from the file.
I've also adjusted the logic for macosx, though I have to say that the logic there still relies on the running interpreter; I really don't know much about macOS, and I don't understand the idea behind versions there, but on the test box I have access to mac_ver() returns 26.x, while platform is macosx-11.0-arm64; and I don't really see a way of getting that 26 out of build-details.json.
Signed-off-by: Michał Górny <mgorny@quansight.com>
This a continuation of #779. For a start, I just did a dumb rebase to rerun the tests.