[BUG] Prefetcher is unrecoverable from exceptions in reset() - #1550
Open
alexdremov wants to merge 1 commit into
Open
[BUG] Prefetcher is unrecoverable from exceptions in reset()#1550alexdremov wants to merge 1 commit into
alexdremov wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Author
|
@ramanishsingh @divyanshk please take a look. This is an annoying bug that does not allow to recover from problems of state restoration. |
Author
|
@ramanishsingh @divyanshk ping |
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
Could this recovery guard be applied to PinMemory.reset() and _ParallelMapper.reset() too? Both still _shutdown(); del self._it before constructing the replacement, so if construction/reset throws they leave _it absent and the next reset hits the same AttributeError this PR fixes for Prefetcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
_SingleThreadedMapperfails for whatever reason,Prefetcherends up in inconsistent state whereself._itis deleted.