Repository navigation
chore(deps): upgrade oxfmt to 0.74 (AI-assisted) - #12808
Merged
Merged
Conversation
oxfmt 0.72.0 changes require more than a version bump: - A negated pattern can't re-include a file below an excluded directory anymore (oxc-project/oxc#27237): re-include the lib/theme directory itself so format-gitignored-files can format the built theme files. - Signed words like -apple-system are no longer split like Prettier does (oxc-project/oxc#27326): reformat the affected CSS font stacks. Replaces the Dependabot PR #12803. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Formatter configuration .oxfmtrc.json, pnpm-workspace.yaml |
The oxfmt catalog version changes from ^0.70.0 to ^0.74.0. The negated ignore pattern no longer includes the recursive ** suffix. |
Blog CSS formatting packages/docusaurus-plugin-content-blog/assets/*.css, packages/docusaurus-plugin-content-blog/src/__tests__/__fixtures__/website/build-snap/blog/*.css, website/_dogfooding/_blog tests/*.css |
The main font-family declarations are formatted on one line. Their font choices and order are unchanged. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related PRs
- meta/docusaurus#12803: Updates the same
oxfmtcatalog entry to^0.74.0.
Suggested reviewers: josh-cena, yangshun
Merge Risk: 
f026f
-
The changes are formatter configuration and formatting-only updates with no evidenced functional regression.
Architecture risk: 
f026f
-
The change affects 3 systems.
Changed systems:
packages/docusaurus-plugin-content-blog,website,pnpm-workspace.yamlArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — packages/docusaurus-plugin-content-blog (library) was modified; 4 changed files map to changed impact.
- observed — website (service) was modified; 2 changed files map to changed impact.
- observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in packages/docusaurus-plugin-content-blog/assets/atom.css: The
mainrule’s multiline font-family declaration was replaced with a single-line declaration containing the same font stack. - observed — Modified behavior in packages/docusaurus-plugin-content-blog/assets/rss.css: The
mainrule’s font-family list is now written on one line; its values and order are unchanged. - observed — Modified behavior in packages/docusaurus-plugin-content-blog/src/tests/fixtures/website/build-snap/blog/atom.css: The
font-familyfallback list was reformatted from a multiline declaration to a single line without changing its values or order. - observed — Modified behavior in packages/docusaurus-plugin-content-blog/src/tests/fixtures/website/build-snap/blog/rss.css: The
mainfont-family stack was reformatted from a multiline declaration to a single line without changing its values.
-
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title "chore(deps): upgrade oxfmt to 0.74 (AI-assisted)" matches the main change. The PR upgrades oxfmt from 0.70 to 0.74 and updates the repository files that the new version requires. The title … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "chore(deps): upgrade oxfmt to 0.74 (AI-assisted)" matches the main change. The PR upgrades oxfmt from 0.70 to 0.74 and updates the repository files that the new version requires. The title is short, specific, and states the primary change. The "(AI-assisted)" suffix adds no information about the code change but does not make the title misleading.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade oxfmt from 0.70 to 0.74.
This replaces the Dependabot PR #12803: a version bump alone can't pass CI, because 2 changes in oxfmt 0.72.0 need changes on our side.
lib/themebuild outputs could no longer be formatted. Since fix(oxfmt): do not re-include a file below an excluded directory with a negated pattern oxc-project/oxc#27237, a negated pattern can't re-include a file whose parent directory is excluded (Git's rule). Ourpackages/docusaurus-*/lib/*pattern excludes thelib/themedirectory itself, so!packages/docusaurus-*/lib/theme/**stopped re-including its files. As a result,format-gitignored-files "lib/theme/**/*.js"failed every package build ("Expected at least one target file"). The fix re-includes the directory itself:!packages/docusaurus-*/lib/theme/.-apple-systemstay on one line. Since fix(formatter_css): fix layouts found in mdn-content repo (css-in-md) oxc-project/oxc#27326, oxfmt intentionally diverges from Prettier: it no longer splits signed words like-apple-systeminto an operator and a word, sofont-family: system-ui, -apple-system, …is no longer broken over several lines. This PR reformats the 4 affected CSS files, and the 2 copies the blog feed tests write to their fixtures (whitespace only).The lockfile is also deduplicated: oxfmt 0.74 brings
tinypool2.2.0.We use 0.74 rather than 0.75 because 0.75.0 was published less than 7 days ago, so our
minimumReleaseAgepolicy blocks it.Test Plan
pnpm installbuilds all the packages again, and the builtlib/themefiles are formatted (checked withoxfmt --list-differenton each file).pnpm lintandpnpm testpass locally.Test links
Deploy preview: https://deploy-preview-12808--docusaurus-2.netlify.app/
The blog feeds use the reformatted CSS:
Related issues/PRs
Replaces #12803
(AI-assisted)
🤖 Generated with Claude Code
Summary by CodeRabbit