Repository navigation
Conversation
…isted) Regression test for exact .html routes with encoded characters: the browser URL is /caf%C3%A9.html while the router decodes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
the
pr: maintenance
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Add the slug test case and screenshot exclusion website/_dogfooding/_docs tests/html-slug-non-ascii.mdx, argos/tests/screenshot.spec.ts |
The MDX document describes the expected route and rendering. The screenshot test blacklist excludes /tests/docs/caf%C3%A9.html. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Other
Possibly related PRs
- meta/docusaurus#12813: Adds static-host screenshot coverage for the same encoded route.
- meta/docusaurus#12810: Updates hydration preloading for normalized paths, including encoded non-ASCII
.htmlroutes.
Merge Risk: 
8a5a0
-
The PR adds the intended non-ASCII HTML-slug fixture and excludes only its encoded route from screenshots.
Architecture risk: 
f4014
-
The change affects 1 system.
Changed systems:
websiteArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — website (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in website/_dogfooding/_blog tests/2022-10-02-html-slug-non-ascii.mdx: Adds an unlisted MDX post with a non-ASCII HTML slug and text describing the expected rendering at its test URL.
-
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the website test and the main change: adding a dogfood document with a non-ASCII HTML slug. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +1.05 kB (+0.01%) Total Size: 12.1 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Size Change: +1.05 kB (+0.01%) Total Size: 12.1 MB 📦 View Changed
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
added
the
Argos
This was referenced Oct 30, 2026
slorber
added
Argos
…repro (AI-assisted) The blog post appeared in the sidebar of every dogfood blog page in the Argos dev build. Like dummy.html, the doc is in no sidebar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
changed the title
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
First PR of a stack: dogfood a doc registered at an exact
.htmlroute with a non-ASCII character,/tests/docs/café.html, next to the existing/tests/docs/dummy.htmldoc.This case works on
main, but is easy to break when changing how the client normalizes and preloads.htmlpathnames: the browser URL is percent-encoded (/caf%C3%A9.html), while the router decodes it. The first version of #12810 broke it.Like
dummy.html, the doc is in no sidebar, so it doesn't change other pages. The regular Argos tests skip it likedummy.html, becausedocusaurus serveredirects.htmlURLs: #12813 screenshots it the way static hosts serve it.(AI-assisted)
Test Plan
Local website builds, opening
/tests/docs/café.htmlwith the client code of:mainTest links
Deploy preview: https://deploy-preview-12812--docusaurus-2.netlify.app/
Related issues/PRs
Stack:
.htmlslug🤖 Generated with Claude Code
Summary by CodeRabbit