Repository navigation
Conversation
… (AI-assisted) pnpm 12.15 lets pnpm-workspace.yaml delegate settings to other files: https://pnpm.io/config-includes On hold until Dependabot, knip and syncpack read the included files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
status: don't merge yet
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pnpm 12.15 lets
pnpm-workspace.yamldelegate settings to other files. This PR upgrades to pnpm 12.15 and moves our catalogs to their ownpnpm-catalogs.yamlfile, so thatpnpm-workspace.yamlonly keeps the workspace and supply chain settings:⏸️ On hold
Don't merge yet: the tools that read our catalogs don't support
includeyet.pnpm-workspace.yaml(file_fetcher.rb) and only updates catalog versions there (pnpm_workspace_updater.rb). pnpm requires the included files to exist, so we expect the npm update jobs to fail.pnpm lint:knipfails with 427 "Unresolved catalog references".minimumReleaseAge)pnpm lint:syncpackpasses with 428DependsOnMissingCatalogDefinitionwarnings.syncpack fixadds acatalog:block topnpm-workspace.yaml, which pnpm rejects withERR_PNPM_DUPLICATE_SETTING.Changes
minimumReleaseAgeyet: onlypnpmis excluded, not its@pnpm/exe.*binaries.pnpm dedupe: pnpm 12.15 deduplicates more, it removesbalanced-match@4.0.4,ci-info@4.4.0andrun-applescript@7.1.0.pnpm-catalogs.yaml,lintCatalogs.js, CSpell and thedependenciesskill updated.includedelegatescatalogs, which covers the default catalog:[catalog, catalogs]fails withERR_PNPM_DUPLICATE_SETTING.The pnpm upgrade can land in a separate PR if we need it before the blockers are fixed.
Test Plan
Locally:
pnpm installandpnpm install --frozen-lockfilepass, the lockfile catalog versions don't changepnpm lint:deps,pnpm lint:catalogsandpnpm lint:syncpackpasspnpm lint:knipfails until we upgrade to knip 6.44.0Test links
Deploy preview: https://deploy-preview-12815--docusaurus-2.netlify.app/
(AI-assisted)
🤖 Generated with Claude Code