Repository navigation
fix foo = classmethod(foo) does not create a working classmethod #3362 - #4796
Open
asukaminato0721 wants to merge 2 commits into
Open
asukaminato0721 wants to merge 2 commits into
asukaminato0721 wants to merge 2 commits into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D118597715. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stroxler
requested changes
Oct 30, 2026
stroxler
left a comment
Contributor
There was a problem hiding this comment.
This needs a rebase before we can merge it, since it has build failures.
In addition, there are some behavior issues:
- Wrong-scope lookup: an inner class’s
f = classmethod(f)can mark an unrelated outer-class method.Outer().f()then incorrectly inferstype[Outer]instead ofOuter. - Aliases change retroactively: saving
g = fbefore wrappingfalso convertsg’s inferred behavior to a classmethod, although it remains an instance method at runtime. - Decorator composition breaks: the flag changes the undecorated function’s receiver before existing decorators run. A valid adapter from an instance-taking function to a class-taking callable gains a false-positive argument error.
- Overloads become inconsistent: only the implementation is marked, producing new
invalid-overloaderrors on otherwise valid overload declarations.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3362
Recognizes
f = classmethod(f)during binding and types cls astype[Self], preserves subclass-aware return inference and class-attribute initialization, avoids triggering when classmethod is shadowed.Test Plan
add test