Skip to content

test: document missing implicit-import quick fixes - #5044

Open
asukaminato0721 wants to merge 1 commit into
meta:mainfrom
asukaminato0721:tests-only-pr-4998
Open

asukaminato0721 wants to merge 1 commit into
meta:mainfrom
asukaminato0721:tests-only-pr-4998

Conversation

@asukaminato0721

@asukaminato0721 asukaminato0721 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The implicit-import warning has no import quick fix. The test checks the diagnostic and the missing action for direct, nested, aliased, and CRLF inputs.

These LSP tests use ordinary Rust #[test] functions, so explicit BUG comments document the incorrect behavior and the correct result. These are passing tests of known bugs, following the repository test guidance.

The complete implementation and regression tests remain in PR #4998. Related issue: #4713.

Validation

Based on upstream main at ef6de648bce0dc6dcca0a21a9fbb7490f23ecce8.

  • cargo test -p pyrefly --lib -- insertion_test_implicit_import — passed.
  • python3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema --no-extension — passed.

@meta-codesync

meta-codesync Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D122390186. (Because this pull request was imported automatically, there will not be any future comments.)

@codspeed

codspeed Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 35 untouched benchmarks
⏩ 9 skipped benchmarks1


Comparing asukaminato0721:tests-only-pr-4998 (00bf75f) with main (dfb38e3)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

This comment has been minimized.

@asukaminato0721 asukaminato0721 changed the title test: cover implicit-import quick fixes test: document missing implicit-import quick fixes Oct 2, 2026
@github-actions github-actions Bot added size/s and removed size/s labels Oct 2, 2026
@github-actions

This comment has been minimized.

@NathanTempest NathanTempest removed their assignment Oct 9, 2026
@github-actions
github-actions Bot requested a review from samwgoldman October 10, 2026 09:10
@github-actions

This comment has been minimized.

@github-actions github-actions Bot added the stale label Oct 25, 2026
@github-actions

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants