Repository navigation
fix(stubs): support float64 subtraction with float - #5366
Closed
mangeshraut712 wants to merge 1 commit into
Closed
mangeshraut712 wants to merge 1 commit into
mangeshraut712 wants to merge 1 commit into
Conversation
The shaped NumPy stubs lost the concrete float64 promotion for a Python float. Add a specific overload ahead of the generic numeric fallback so the operation is accepted and preserves its dtype.
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D127482634. (Because this pull request was imported automatically, there will not be any future comments.) |
stroxler
approved these changes
Oct 26, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
Actually this is superseded by #5367 and they can't both land, so I'm closing this in favor of the other (thanks for working on this!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.float64 - floatwas reported as unsupported. Add afloat64.__sub__overload for built-infloat(preservingfloat64) and a focused regression in the dtype-properties suite.Fixes #5353
Test plan
run_runtime_tests.py --suite dtype-properties