Repository navigation
fix(stubgen): preserve from __future__ import annotations - #5369
mangeshraut712 wants to merge 2 commits into
Conversation
Keep copied __future__ imports at the top of generated stubs so added typing imports do not make them invalid Python.
|
This pull request has been imported. If you are a Meta employee, you can view this in D127483012. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in f819cf2. |
|
Hey — CodeSync landed this on main with me as the commit author (thanks). GitHub still shows the PR as closed not merged ( Could you mark CodeSync landings as merged on the GitHub side (or reopen + merge via GitHub) so external contributors get the PR merge credit? Same issue on #5365 #5373 #5367 #5369. |
Closes #5321.