Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@ESoapW has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127204480. |
…#589) Summary: facebook/time's GitHub lint job fails on the exported D124865748: fbclock/data_read.go:122:19: Error return value of `unix.Munmap` is not checked (errcheck) The deferred Munmap only drops a read-only mapping after the snapshot is copied, so there's nothing to do with its error. This discards it explicitly, as shmem_notlinux.go's deferred Munmaps do. Internal lint doesn't report it: arc lint, extra linters included, passes on the unchanged line. Differential Revision: D127204480
meta-codesync
Bot
changed the title
ESoapW
force-pushed
the
export-D127204480
branch
from
October 23, 2026 18:34
0da1525 to
7cb2766
Compare
Contributor
|
This pull request has been merged in 70873ed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
facebook/time's GitHub lint job fails on the exported D124865748:
fbclock/data_read.go:122:19: Error return value of
unix.Munmapis not checked (errcheck)The deferred Munmap only drops a read-only mapping after the snapshot is copied, so there's nothing to do with its error. This discards it explicitly, as shmem_notlinux.go's deferred Munmaps do.
Internal lint doesn't report it: arc lint, extra linters included, passes on the unchanged line.
Differential Revision: D127204480