Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a platform-specific file-writing helper that retries transient Windows file-sharing violations when
FilePatchToolandFileWriteToolwrite files.Problem
On Windows, file-writing operations can intermittently fail with
ERROR_SHARING_VIOLATION(Win32 error 32) during repeated read-and-write sequences. This can cause otherwise valid file operations and tests to fail intermittently.Changes
writeToolFileimplementation with bounded retries forERROR_SHARING_VIOLATION.os.WriteFile.Verification
Verified locally on Windows with Go 1.27.3:
gofmt -l .go vet ./...go test ./... -count=1go test ./internal/tools -run "^TestWriteToolFile_" -vAll listed checks passed in the reported local environment. Native macOS testing was not performed.
Scope
This PR focuses exclusively on the Windows file-writing fix and its tests. Fork-specific CI changes are intentionally excluded.