Exports using module.exports for node v8 support - #24
Open
cammanderson wants to merge 1 commit into
Open
Conversation
Owner
|
Sorry for the delay in responding. First thought: Moving the source-code away from ES6 modules is like taking a step backward. Your motivation is to be able to load the library without requiring the polyfill? That's fair enough, but I don't see a real downside to having a build-step. Want you like to try to provide that build-step? Second thought: For libraries I don't see the point of committing Third thought: Have you looked at the failing CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using module.exports for the class, node v8 (Current Node LTS) is able to load the library without babel polyfills or other transpiler.
I ran the 'pp' task which passed, and this is the result. I have included the src using node v8 and it loads without any further runtime.