Add incremental TF-IDF learning fix for chatbot sample (issue #157)#189
Open
Hardikrepo wants to merge 1 commit into
Open
Add incremental TF-IDF learning fix for chatbot sample (issue #157)#189Hardikrepo wants to merge 1 commit into
Hardikrepo wants to merge 1 commit into
Conversation
Avoids O(n^2) growth from refitting the vectorizer on every learn_from_pair call by appending via scipy.sparse.vstack and rebuilding only periodically.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
learn_from_pairrefit the entire TF-IDF vectorizer on every call.transform()for new examples and appends viascipy.sparse.vstack(O(1) amortized per call), with a periodic full rebuild (default every 20 additions) to resync vocabulary/IDF weights.Context
See discussion in #157 for the original script and review comments identifying the O(n^2) issue and suggesting an incremental approach.
Test plan
community-samples/tfidf-chatbot-incremental-fix/simple_chatbot.pyinteractively and confirmlearn:commands work and responses remain correct after several incremental learns.