[Master] - Bug 646815 [Expense Agent] Obsolete country-specific demo data, consolidating into single W1 app - #10249
Open
v-rohangarg20 wants to merge 1 commit into
Open
Conversation
v-rohangarg20
marked this pull request as ready for review
August 15, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workitem Bug 646815: [master] [Expense Agent] [Demo Data] Obsolete country-specific demo data, consolidating into single W1 app
Fixes AB#646815
Issue: After the Expense Agent demo data was consolidated into a single W1 app, the old country-specific demo data codeunits (AT, AU, CA, DE, DK, ES, FR, GB, NZ, US) were still present and active. Keeping them alongside the consolidated W1 demo data caused duplicated demo data generation and left dead, redundant objects in the country apps that needed a clean deprecation path before removal.
Cause: Each country still shipped its own set of Expense demo data codeunits — G/L accounts, posting groups, employee posting-group updates, expense categories/subcategories, rule headers/conditions, expenses, posted expense reports, and the Exp. Contoso Localization subscribers. These are now superseded by the single W1 app, but they cannot simply be deleted because external consumers may still reference them; they require a proper obsoletion window first.
Solution: Marked all country-specific Expense Agent demo data as obsolete (~101 files). Each codeunit is wrapped in #if not CLEAN29 / #endif so it compiles out under the CLEAN29 flag, and annotated with ObsoleteState = Pending, ObsoleteTag = '29.0', and ObsoleteReason = 'The country-specific Expense Agent demo data is being consolidated into a single app in W1 and will be removed in a future release.', with #pragma warning disable AL0432 where they reference other now-obsolete objects. Behavior is unchanged for non-CLEAN29 builds — the objects stay functional through the deprecation window and are excluded under CLEAN29, ready for full removal in a future release.