Skip to content

Bug 550732: Keep routing descriptions when vendor changes - #10259

Open
Chethan Thopaiah (ChethanT) wants to merge 1 commit into
mainfrom
bugs/550732-keep-requisition-description
Open

Bug 550732: Keep routing descriptions when vendor changes#10259
Chethan Thopaiah (ChethanT) wants to merge 1 commit into
mainfrom
bugs/550732-keep-requisition-description

Conversation

@ChethanT

@ChethanT Chethan Thopaiah (ChethanT) commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve subcontracting requisition Description and Description 2 from the matching production order routing line when the vendor changes
  • retain the existing work-center fallback when the routing line is missing, belongs to another work center, or has a blank Description 2
  • apply the same fix to the IT BaseApp layer

Root Cause

Vendor validation refreshed requisition descriptions from the subcontracting work center instead of the production order routing operation.

Test

Added \ChangingVendorKeepsProdOrderRoutingLineDescriptions\ ([SCENARIO 550732]) in codeunit 139989.

Validation:

  • Subcontracting app compile: passed, 0 warnings/errors
  • Subcontracting test app compile: passed, 0 warnings/errors
  • app/test publish: passed
  • regression test against the currently published unmodified Base Application: failed as expected, proving the old behavior
  • final execution with the updated Base Application is blocked locally by the existing Base Application compiler/platform AL0126 mismatch; CI should run the integrated validation

Fixes AB#550732

🤖 Generated with GitHub Copilot

Use the production order routing line descriptions when a subcontracting requisition line refreshes after a vendor change, and add regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ChethanT
Chethan Thopaiah (ChethanT) requested a review from a team August 14, 2026 14:45
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area labels Aug 14, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 14, 2026
end;

[Test]
procedure ChangingVendorKeepsProdOrderRoutingLineDescriptions()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Testing}$

The new test ChangingVendorKeepsProdOrderRoutingLineDescriptions only covers the branch where the production order routing line is found and its own Description/Description 2 are reused. It does not exercise the new fallback branch (added identically in both the W1 and IT layer tableextensions) that restores the Work Center's Name/Name 2 when ProdOrderRoutingLine.Get(...) returns false or the routing line's "Work Center No." no longer matches the requisition line's "Work Center No.". A regression in that fallback path (e.g. accidentally always taking the routing-line branch, or an inverted condition) could ship without any test failing. Add a negative test that forces RoutingLineFound = false (or a work-center mismatch) and asserts the requisition line falls back to the work-center descriptions.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.33.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant