Refine self-improvement review guidance - #132
Open
Wenjie Fan (gggdttt) wants to merge 2 commits into
Open
Conversation
Narrow IsHandled, label-scope, UI-handler, checkpoint, and bulk-operation guidance to evidence-backed false-positive boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve independent event seams, cover loop-carried handled state, strengthen checkpoint and UI-handler fixtures, and align DeleteAll fallback guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 10646e50-2d8b-4cca-b02b-dfa78629e6a1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine the second self-improvement batch into evidence-backed BCQuality guidance rather than copying reaction-generated changes verbatim.
IsHandledreset findings to values that can actually carrytrue, including loop-carried stateModifyAll/DeleteAllfallback guidance with documented platform conditionsFalse-positive boundaries
falsefor one non-looping raise. A local declared outside a loop initializes once and can carrytrueacross iterations. A later raise reached only after a semantically validif IsHandled then exit;remains proven false.[HandlerFunctions]proves listed handlers execute. Missing semantic verification isminor; queue storage is not mandatory for every handler. Fixtures cover omitted handlers, listed-but-unreached handlers, and meaningful capture/assert verification.FindSetremains unbounded, and the checkpoint sample initializes its persisted watermark on cold start.Validation
python .github/scripts/validate_frontmatter.py --root .tools/Test-ReviewFixtures.ps1 -Root . -PrepareDirectory <temp>.github/scripts/Test-KnowledgeIndex.ps1 -Root .git diff --checkDeliberately unchanged
internal-access-is-not-a-security-boundary