Skip to content

Refine self-improvement review guidance - #132

Open
Wenjie Fan (gggdttt) wants to merge 2 commits into
mainfrom
gggdttt-refine-self-improvement-guidance
Open

Refine self-improvement review guidance#132
Wenjie Fan (gggdttt) wants to merge 2 commits into
mainfrom
gggdttt-refine-self-improvement-guidance

Conversation

@gggdttt

@gggdttt Wenjie Fan (gggdttt) commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Refine the second self-improvement batch into evidence-backed BCQuality guidance rather than copying reaction-generated changes verbatim.

  • narrow IsHandled reset findings to values that can actually carry true, including loop-carried state
  • retire local Label scope as a correctness/localization rule
  • allow semantic capture/reset/assert UI-handler tests and reserve queues for interaction contracts
  • require restart-safe persisted checkpoints without weakening bounded retrieval
  • align ModifyAll/DeleteAll fallback guidance with documented platform conditions

False-positive boundaries

  • A fresh local Boolean is already false for one non-looping raise. A local declared outside a loop initializes once and can carry true across iterations. A later raise reached only after a semantically valid if IsHandled then exit; remains proven false.
  • Independent event seams use independent handled state so one handled event does not suppress a downstream publisher.
  • Procedure-local Labels are supported and included in the extension translation pipeline; object scope is only a possible maintainability convention.
  • [HandlerFunctions] proves listed handlers execute. Missing semantic verification is minor; queue storage is not mandatory for every handler. Fixtures cover omitted handlers, listed-but-unreached handlers, and meaningful capture/assert verification.
  • Persisted retry progress and bounded next-N retrieval are separate requirements. A full-tail FindSet remains unbounded, and the checkpoint sample initializes its persisted watermark on cold start.
  • Progress UX permits an explicit row loop only when the equivalent bulk API already falls back to individual operations and semantics are preserved. DeleteAll guidance includes trigger code, related subscribers, security filtering, Media/MediaSet, and companion-field fallback conditions.

Validation

  • python .github/scripts/validate_frontmatter.py --root .
  • tools/Test-ReviewFixtures.ps1 -Root . -PrepareDirectory <temp>
  • .github/scripts/Test-KnowledgeIndex.ps1 -Root .
  • git diff --check

Deliberately unchanged

  • internal-access-is-not-a-security-boundary
  • ErrorInfo boundary guidance
  • the PR #7938 unreachable-case candidate
  • no swallowed-handler-assertion warning
  • existing article slugs and paths

Narrow IsHandled, label-scope, UI-handler, checkpoint, and bulk-operation guidance to evidence-backed false-positive boundaries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve independent event seams, cover loop-carried handled state, strengthen checkpoint and UI-handler fixtures, and align DeleteAll fallback guidance.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 10646e50-2d8b-4cca-b02b-dfa78629e6a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant