Repository navigation
Pin GitHub Actions to full-length commit SHAs - #1051
Closed
Dan Fiedler (danfiedler-msft) wants to merge 1 commit into
Closed
Dan Fiedler (danfiedler-msft) wants to merge 1 commit into
Dan Fiedler (danfiedler-msft) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the repository’s CI/CD security posture by pinning GitHub Actions to full-length commit SHAs (improving reproducibility and reducing tag-retargeting risk) and introducing a Dependabot cooldown for GitHub Actions updates.
Changes:
- Replaced tag-based
uses: ...@vXreferences with full commit SHAs across workflows (with version comments). - Added a Dependabot
cooldownconfiguration intended for thegithub-actionsecosystem. - Updated multiple workflow files to apply the pinned-action references consistently.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/validate-bicep-params.yml | Pin checkout, setup-python, and upload-artifact to SHAs. |
| .github/workflows/test.yml | Pin checkout and setup-python to SHAs. |
| .github/workflows/test-automation.yml | Pin checkout, setup-python, and upload-artifact to SHAs. |
| .github/workflows/telemetry-template-check.yml | Pin checkout to a SHA. |
| .github/workflows/stale-bot.yml | Pin actions/stale, checkout, and upload-artifact to SHAs. |
| .github/workflows/Scheduled-Dependabot-PRs-Auto-Merge.yml | Pin checkout to a SHA. |
| .github/workflows/pylint.yml | Pin checkout and setup-python to SHAs. |
| .github/workflows/pr-title-checker.yml | Pin amannn/action-semantic-pull-request to a SHA. |
| .github/workflows/job-test-automation.yml | Pin checkout, setup-python, and upload-artifact to SHAs. |
| .github/workflows/job-docker-build.yml | Pin checkout, Docker actions, and azure/login to SHAs. |
| .github/workflows/job-deploy-windows.yml | Pin checkout, Azure/setup-azd, and azure/login to SHAs. |
| .github/workflows/job-deploy-linux.yml | Pin checkout, Azure/setup-azd, and azure/login to SHAs. |
| .github/workflows/job-cleanup-resources.yml | Pin azure/login to a SHA. |
| .github/workflows/job-azure-deploy.yml | Pin checkout and azure/login to SHAs. |
| .github/workflows/docker-build.yml | Pin checkout, Docker actions, and azure/login to SHAs. |
| .github/workflows/deploy.yml | Pin checkout, setup-python, and peaceiris/actions-gh-pages to SHAs. |
| .github/workflows/deploy-KMGeneric.yml | Pin checkout and azure/login to SHAs. |
| .github/workflows/codeql.yml | Pin checkout, setup-dotnet, and CodeQL actions to SHAs. |
| .github/workflows/broken-links-checker.yml | Pin checkout and lycheeverse/lychee-action to SHAs. |
| .github/workflows/bicep_deploy.yml | Pin checkout and azure/login to SHAs. |
| .github/workflows/azure-dev.yml | Pin checkout, Azure/setup-azd, and azure/login to SHAs. |
| .github/workflows/azd-template-validation.yml | Pin checkout and microsoft/template-validation-action to SHAs. |
| .github/dependabot.yml | Add Dependabot cooldown configuration for GitHub Actions updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
18
to
21
| # Python backend dependencies - grouped | ||
| cooldown: | ||
| default-days: 7 | ||
| - package-ecosystem: "pip" |
Comment on lines
60
to
63
| - name: Setup dotnet ${{ matrix.dotnet-version }} | ||
| uses: actions/setup-dotnet@v5 | ||
| uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0 | ||
| with: | ||
| dotnet-version: ${{ matrix.dotnet-version }} |
Contributor
|
"Thanks for raising, we already merged the required changes, so closing this PR" PR- #1049 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR pins GitHub Actions to full-length commit SHAs for improved security and reproducibility and adds a 7 day cooldown to Dependabot configuration for GitHub Actions. This work is described in more detail at https://aka.ms/action-pinning.
Why?
Pinning actions to commit SHAs prevents supply-chain attacks where a tag could be moved to point to malicious code. This is a recommended security best practice per the GitHub Actions security hardening guide.
This change mitigates the risk of tag retargeting to malicious code as seen in incidents like the tj-actions/changed-files action compromise or codfish/semantic-release-action compromise and improves the integrity and reproducibility of the CI/CD pipeline.
What changed?
Action pinning: Third-party action references in
.github/workflows/that used mutable tag-based references (e.g.,actions/checkout@v4) have been updated to full-length commit SHAs with a version comment (e.g.,actions/checkout@<sha> # v4) using the pinact tool. References that were already pinned to a SHA, or that used immutable release tags, were left unchanged.Dependabot configuration:
.github/dependabot.ymlhas been updated to ensure agithub-actionspackage-ecosystem section is present with acooldownconfiguration (default-days: 7). If the file did not exist, it was created. If agithub-actionssection already existed, only thecooldownblock was added or itsdefault-daysvalue was increased to 7 if it was lower. The 7-day cooldown provides a window for the community to detect and report compromised releases before they are automatically proposed as updates, reducing exposure to supply-chain attacks via newly published malicious versions.Is this safe to merge?
Yes. The pinned SHAs correspond to the same commits that the existing tags pointed to. No behavioral changes in action execution are introduced. You can verify the pinned SHA value using the GitHub REST API (e.g., the commit hash for
actions/checkout@v7can be found in theshaproperty in the JSON response forGET https://api.github.com/repos/actions/checkout/commits/v7).Additional Information
For more information, please see https://aka.ms/action-pinning