Support find_package for GTest - #1257
Open
true-brace05 wants to merge 1 commit into
Open
Conversation
Author
|
Hi, I've submitted a PR for this issue: #1257. Looking forward to your review. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a higher-priority detection path for GoogleTest in tests/CMakeLists.txt so builds can reuse an already-installed GTest (e.g., via vcpkg/CMake package configs) instead of downloading and building it, while retaining the existing download fallback for environments without a preinstalled GTest.
Changes:
- Attempt to locate GoogleTest via
find_package(GTest QUIET)before usingpkg_search_module. - Keep the existing “download via Git” fallback when no preinstalled GoogleTest is found.
Show a summary per file
| File | Description |
|---|---|
| tests/CMakeLists.txt | Adds find_package(GTest) as a pre-check before pkg-config detection and the existing download fallback. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
+25
to
+35
| find_package(GTest QUIET) | ||
|
|
||
| if(GTest_FOUND) | ||
| set(GTestMain_LIBRARIES GTest::gtest_main) | ||
| endif() | ||
|
|
||
| if(NOT GTest_FOUND) | ||
| pkg_search_module(GTestMain gtest_main) | ||
| endif() | ||
|
|
||
| if(NOT GTest_FOUND AND NOT GTestMain_FOUND) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change attempts to locate a pre-installed GoogleTest using
find_package(GTest QUIET)before falling back topkg_search_moduleand downloading GoogleTest.This avoids redundant downloads when GoogleTest is already installed through CMake package managers such as vcpkg, while preserving the existing fallback behavior.
Fixes #1256